Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

Issue 2565113002: DevTools: update console viewport scroll when prompt is resized (Closed)
Patch Set: rebaseline Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
index a7eb7f9ecb6135d47d4ce7e24e301e7e99af1744..a6f53ca44ec8760a5ffb915063d6bf899ee312de 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
@@ -32,6 +32,7 @@ Console.ConsolePrompt = class extends UI.Widget {
});
this._editor.widget().element.addEventListener('keydown', this._editorKeyDown.bind(this), true);
this._editor.widget().show(this.element);
+ this._editor.addEventListener(UI.TextEditor.Events.TextChanged, this._onTextChanged, this);
this.setText(this._initialText);
delete this._initialText;
@@ -43,6 +44,10 @@ Console.ConsolePrompt = class extends UI.Widget {
}
}
+ _onTextChanged() {
+ this.dispatchEventToListeners(Console.ConsolePrompt.Events.TextChanged);
+ }
+
/**
* @return {!Console.ConsoleHistoryManager}
*/
@@ -75,6 +80,7 @@ Console.ConsolePrompt = class extends UI.Widget {
this._editor.setText(text);
else
this._initialText = text;
+ this.dispatchEventToListeners(Console.ConsolePrompt.Events.TextChanged);
}
/**
@@ -137,7 +143,6 @@ Console.ConsolePrompt = class extends UI.Widget {
this._editor.setSelection(TextUtils.TextRange.createFromLocation(0, Infinity));
else
this.moveCaretToEndOfPrompt();
- this.setMinimumSize(0, this._editor.widget().element.offsetHeight);
}
/**
@@ -372,3 +377,7 @@ Console.ConsoleHistoryManager = class {
return this._data[this._data.length - this._historyOffset];
}
};
+
+Console.ConsolePrompt.Events = {
+ TextChanged: Symbol('TextChanged')
+};

Powered by Google App Engine
This is Rietveld 408576698