Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

Issue 2565113002: DevTools: update console viewport scroll when prompt is resized (Closed)
Patch Set: yay Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
index 24a8c743245606e87946846046e50cc766a25751..9b3c71218af8ea149cb92c100286d2c9a02753df 100644
--- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
@@ -53,9 +53,7 @@ SourceFrame.SourceFrame = class extends UI.SimpleView {
SourceFrame.SourcesTextEditor.Events.EditorFocused, this._resetCurrentSearchResultIndex, this);
this._textEditor.addEventListener(
SourceFrame.SourcesTextEditor.Events.SelectionChanged, this._updateSourcePosition, this);
- this._textEditor.addEventListener(
- SourceFrame.SourcesTextEditor.Events.TextChanged,
- event => this.onTextChanged(event.data.oldRange, event.data.newRange));
+ this._textEditor.on(UI.TextEditor.TextChangedEvent, event => this.onTextChanged(event.oldRange, event.newRange));
pfeldman 2017/03/24 22:28:33 So I encapsulate this._textEditor, I call editRang
luoe 2017/03/28 17:40:41 We want to redo the search highlight when text cha
this._shortcuts = {};
this.element.addEventListener('keydown', this._handleKeyDown.bind(this), false);

Powered by Google App Engine
This is Rietveld 408576698