Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2565113002: DevTools: update console viewport scroll when prompt is resized (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index 6f0d6aa9836a3ef806e4333544ba3b655ea86b3f..7c1b5105a3b79260fea82450f1caf835ea944e54 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -376,7 +376,7 @@ Console.ConsoleView = class extends UI.VBox {
* @override
*/
onResize() {
- this._scheduleViewportRefresh();
+ this.scheduleViewportRefresh();
this._hidePromptSuggestBox();
if (this._viewport.stickToBottom())
this._immediatelyScrollToBottom();
@@ -388,7 +388,7 @@ Console.ConsoleView = class extends UI.VBox {
this._prompt.clearAutocomplete();
}
- _scheduleViewportRefresh() {
+ scheduleViewportRefresh() {
/**
* @this {Console.ConsoleView}
* @return {!Promise.<undefined>}
@@ -408,10 +408,10 @@ Console.ConsoleView = class extends UI.VBox {
}
if (this._muteViewportUpdates) {
this._maybeDirtyWhileMuted = true;
- this._scheduleViewportRefreshForTest(true);
+ this.scheduleViewportRefreshForTest(true);
return;
} else {
- this._scheduleViewportRefreshForTest(false);
+ this.scheduleViewportRefreshForTest(false);
}
this._viewportThrottler.schedule(invalidateViewport.bind(this));
}
@@ -419,7 +419,7 @@ Console.ConsoleView = class extends UI.VBox {
/**
* @param {boolean} muted
*/
- _scheduleViewportRefreshForTest(muted) {
+ scheduleViewportRefreshForTest(muted) {
// This functions is sniffed in tests.
}
@@ -481,7 +481,7 @@ Console.ConsoleView = class extends UI.VBox {
this._needsFullUpdate = true;
}
- this._scheduleViewportRefresh();
+ this.scheduleViewportRefresh();
this._consoleMessageAddedForTest(viewMessage);
}
@@ -1011,7 +1011,7 @@ Console.ConsoleView = class extends UI.VBox {
this._muteViewportUpdates = false;
this._viewport.setStickToBottom(this._messagesElement.isScrolledToBottom());
if (this._maybeDirtyWhileMuted) {
- this._scheduleViewportRefresh();
+ this.scheduleViewportRefresh();
delete this._maybeDirtyWhileMuted;
}
delete this._waitForScrollTimeout;

Powered by Google App Engine
This is Rietveld 408576698