DevTools: update console viewport scroll when prompt is resized

third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 35 matching lines @@
 
     this._textEditor = new SourceFrame.SourcesTextEditor(this);
 
     this._currentSearchResultIndex = -1;
     this._searchResults = [];
 
     this._textEditor.addEventListener(
         SourceFrame.SourcesTextEditor.Events.EditorFocused, this._resetCurrentSearchResultIndex, this);
     this._textEditor.addEventListener(
         SourceFrame.SourcesTextEditor.Events.SelectionChanged, this._updateSourcePosition, this);
-    this._textEditor.addEventListener(
-        SourceFrame.SourcesTextEditor.Events.TextChanged,
-        event => this.onTextChanged(event.data.oldRange, event.data.newRange));
+    this._textEditor.on(UI.TextEditor.TextChangedEvent, event => {
+      if (!this._muteChangeEventsForSetContent)
+        this.onTextChanged(event.oldRange, event.newRange);
+    });
+    /** @type {boolean|undefined} */
+    this._muteChangeEventsForSetContent;

[luoe, 2017/03/31 02:18:08]

AFAICT, the reason why we had muteTextChangedEvents at all was because we didn't
want to do things like set working copy, update last modified time, etc when
opening a file and calling setContent().  I think it makes more sense to move
the mute logic from the low level CMTE up to SourceFrame, where the setContent()
exists.

Is wrapping the onTextChanged callback in an 'if' check too strange?

After this patch, CodeMirror will always emit a UI.TextEditor.TextChanged event
when it changes, and SourceFrame, the only one that cares about muting, will be
the only place that knows about this muting logic at all.

[pfeldman, 2017/04/04 20:21:09]

Makes sense to me.

 
     this._shortcuts = {};
     this.element.addEventListener('keydown', this._handleKeyDown.bind(this), false);
 
     this._sourcePosition = new UI.ToolbarText();
 
     /**
      * @type {?UI.SearchableView}
      */
     this._searchableView = null;
@@ skipping 188 matching lines @@
    * @param {string} content
    */
   _updateHighlighterType(content) {
     this._textEditor.setMimeType(this._simplifyMimeType(content, this._highlighterType));
   }
 
   /**
    * @param {?string} content
    */
   setContent(content) {
+    this._muteChangeEventsForSetContent = true;
     if (!this._loaded) {
       this._loaded = true;
       this._textEditor.setText(content || '');
       this._textEditor.markClean();
       this._textEditor.setReadOnly(!this._editable);
     } else {
       var scrollTop = this._textEditor.scrollTop();
       var selection = this._textEditor.selection();
       this._textEditor.setText(content || '');
       this._textEditor.setScrollTop(scrollTop);
       this._textEditor.setSelection(selection);
     }
 
     this._updateHighlighterType(content || '');
     this._wasShownOrLoaded();
 
     if (this._delayedFindSearchMatches) {
       this._delayedFindSearchMatches();
       delete this._delayedFindSearchMatches;
     }
+    delete this._muteChangeEventsForSetContent;
     this.onTextEditorContentSet();
   }
 
   onTextEditorContentSet() {
   }
 
   /**
    * @param {?UI.SearchableView} view
    */
   setSearchableView(view) {
@@ skipping 279 matching lines @@
     }
   }
 
   _handleKeyDown(e) {
     var shortcutKey = UI.KeyboardShortcut.makeKeyFromEvent(e);
     var handler = this._shortcuts[shortcutKey];
     if (handler && handler())
       e.consume(true);
   }
 };