DevTools: update console viewport scroll when prompt is resized

third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 Console.ConsolePrompt = class extends UI.Widget {
   constructor() {
     super();
     this._addCompletionsFromHistory = true;
@@ skipping 14 matching lines @@
       this._editor =
           factory.createEditor({lineNumbers: false, lineWrapping: true, mimeType: 'javascript', autoHeight: true});
 
       this._editor.configureAutocomplete({
         substituteRangeCallback: this._substituteRange.bind(this),
         suggestionsCallback: this._wordsWithQuery.bind(this),
         captureEnter: true
       });
       this._editor.widget().element.addEventListener('keydown', this._editorKeyDown.bind(this), true);
       this._editor.widget().show(this.element);
+      this._editor.widget().on(UI.TextEditor.TextChangedEvent, this._onTextChanged, this);

[pfeldman, 2017/03/24 22:28:33]

You don't know that the widget is editor, this callback should have been in the
configureAutocomplete, right?

[luoe, 2017/03/28 17:40:41]

einbinder@, wdyt about adding a text changed handler into a configuration
object?  TextEditors are Widgets, but also an interface.  Sounds like it was
originally done to appease closure compiler. 
 einbinder@ has a separate CL to make TextEditor an abstract class that extends
widget:

https://codereview.chromium.org/2778873003/

[luoe, 2017/03/31 02:18:08]

Done, Updated TextEditor to extend Common.EventTarget.

 
       this.setText(this._initialText);
       delete this._initialText;
       if (this.hasFocus())
         this.focus();
       this.element.tabIndex = -1;
 
       this._editorSetForTest();
     }
   }
 
+  _onTextChanged() {
+    this.emit(new Console.ConsolePrompt.TextChangedEvent());
+  }
+
   /**
    * @return {!Console.ConsoleHistoryManager}
    */
   history() {
     return this._history;
   }
 
   clearAutocomplete() {
     if (this._editor)
       this._editor.clearAutocomplete();
@@ skipping 12 matching lines @@
   }
 
   /**
    * @param {string} text
    */
   setText(text) {
     if (this._editor)
       this._editor.setText(text);
     else
       this._initialText = text;
+    this.emit(new Console.ConsolePrompt.TextChangedEvent());
   }
 
   /**
    * @return {string}
    */
   text() {
     return this._editor ? this._editor.text() : this._initialText;
   }
 
   /**
@@ skipping 42 matching lines @@
 
     if (newText === undefined)
       return;
     keyboardEvent.consume(true);
     this.setText(newText);
 
     if (isPrevious)
       this._editor.setSelection(Common.TextRange.createFromLocation(0, Infinity));
     else
       this.moveCaretToEndOfPrompt();
-    this.setMinimumSize(0, this._editor.widget().element.offsetHeight);
   }
 
   /**
    * @param {!KeyboardEvent} event
    */
   _enterKeyPressed(event) {
     if (event.altKey || event.ctrlKey || event.shiftKey)
       return;
 
     event.consume(true);
@@ skipping 210 matching lines @@
     return this._currentHistoryItem();
   }
 
   /**
    * @return {string|undefined}
    */
   _currentHistoryItem() {
     return this._data[this._data.length - this._historyOffset];
   }
 };
+
+/** @implements {Common.Emittable} */
+Console.ConsolePrompt.TextChangedEvent = class {};