Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 25650002: Fixed a runtime error caused by incomplete manifestTypes in _api_features.json (Closed)

Created:
7 years, 2 months ago by sergeygs
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fixed a runtime error caused by incomplete manifestTypes in _api_features.json BUG=302841 R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226498

Patch Set 1 #

Total comments: 1

Patch Set 2 : Modified solution as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sergeygs
7 years, 2 months ago (2013-10-02 00:02:08 UTC) #1
not at google - send to devlin
nice, thanks for fixing this. lgtm with "contexts": ["blessed_extension"] instead. https://codereview.chromium.org/25650002/diff/1/chrome/common/extensions/api/_api_features.json File chrome/common/extensions/api/_api_features.json (right): https://codereview.chromium.org/25650002/diff/1/chrome/common/extensions/api/_api_features.json#newcode331 ...
7 years, 2 months ago (2013-10-02 00:03:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeygs@chromium.org/25650002/5001
7 years, 2 months ago (2013-10-02 00:07:18 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 01:50:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeygs@chromium.org/25650002/5001
7 years, 2 months ago (2013-10-02 17:57:57 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 17:59:35 UTC) #6
Message was sent while issue was closed.
Change committed as 226498

Powered by Google App Engine
This is Rietveld 408576698