Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: chrome/browser/ui/extensions/

Issue 2564973002: Add an infobar if a session is being controlled by an automated test. (Closed)
Patch Set: avoid changes to GlobalConfirmInfoBar Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/
diff --git a/chrome/browser/ui/extensions/ b/chrome/browser/ui/extensions/
index ddbfadf60e28dcca2f43f6d58079547727e2420d..a589bd71f4fe40705925dfc502ead4e3e4a0c96e 100644
--- a/chrome/browser/ui/extensions/
+++ b/chrome/browser/ui/extensions/
@@ -21,6 +21,7 @@
#include "chrome/browser/ui/startup/startup_browser_creator.h"
#include "chrome/common/channel_info.h"
#include "components/version_info/version_info.h"
+#include "content/public/common/content_switches.h"
#include "extensions/common/feature_switch.h"
namespace {
@@ -84,6 +85,14 @@ bool EnableDevModeBubble() {
if (extensions::FeatureSwitch::force_dev_mode_highlighting()->IsEnabled())
return true;
+ // If ChromeDriver is controlling the browser, we don't show the dev mode
+ // bubble because it interferes with focus. This isn't a security concern
+ // because we'll instead show an (even scarier) infobar. See also
+ // ChromeDriverInfoBarDelegate.
+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+ if (command_line->HasSwitch(switches::kEnableChromeDriver))
+ return false;
#if defined(OS_WIN)
if (chrome::GetChannel() >= version_info::Channel::BETA)
return true;

Powered by Google App Engine
This is Rietveld 408576698