Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: content/public/browser/screen_orientation_provider.cc

Issue 2564953003: Fix reversed DCHECK() in ScreenOrientationProvider. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/screen_orientation_provider.cc
diff --git a/content/public/browser/screen_orientation_provider.cc b/content/public/browser/screen_orientation_provider.cc
index e80c8625b8bc0a3cac1d02b6b10596e9060ddc52..bb7cf8d14f75b6ec55ef96fed9d0e8429733cd36 100644
--- a/content/public/browser/screen_orientation_provider.cc
+++ b/content/public/browser/screen_orientation_provider.cc
@@ -28,10 +28,9 @@ ScreenOrientationProvider::~ScreenOrientationProvider() {
void ScreenOrientationProvider::LockOrientation(
blink::WebScreenOrientationLockType orientation,
const LockOrientationCallback& callback) {
- // ScreenOrientation should have cancelled all pending request at thie point.
+ // ScreenOrientation should have cancelled all pending request at this point.
DCHECK(on_result_callback_.is_null());
- DCHECK(pending_lock_orientation_.has_value());
- DCHECK(pending_lock_orientation_.value() >= 0);
+ DCHECK(!pending_lock_orientation_.has_value());
on_result_callback_ = callback;
if (!delegate_ || !delegate_->ScreenOrientationProviderSupported()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698