pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart - Issue 2564913002: Implement SearchEngine.searchAllSubtypes() with the analysis driver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

Issue 2564913002: Implement SearchEngine.searchAllSubtypes() with the analysis driver. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart ('k') | pkg/analysis_server/lib/src/services/search/hierarchy.dart » ('j') | pkg/analysis_server/test/services/search/search_engine2_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

index 5c9e12f1d0b381fae03dde6046de9c853e8c575d..0e802d646bdb2987801443c24e4facd91c772198 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

@@ -164,7 +164,7 @@ class _ClassMemberValidator {

Set<ClassElement> superClasses = getSuperClasses(elementClass);

await _prepareReferences();

Set<ClassElement> subClasses =

- await getSubClasses(searchEngine, elementClass);

+ await searchEngine.searchAllSubtypes(elementClass);

// check shadowing of class names

if (element != null) {

for (Element element in elements) {