Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: ui/app_list/cocoa/app_list_view_controller.mm

Issue 25649004: Always tear down the OSX app list signin view, when the signin status changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/cocoa/app_list_view_controller.mm
diff --git a/ui/app_list/cocoa/app_list_view_controller.mm b/ui/app_list/cocoa/app_list_view_controller.mm
index f00da9c742b7a0c1a4240f49a66161a54503fa1b..5e5eea5c655882615797e73ef51209d7ac76ea6c 100644
--- a/ui/app_list/cocoa/app_list_view_controller.mm
+++ b/ui/app_list/cocoa/app_list_view_controller.mm
@@ -339,12 +339,11 @@ void AppListModelObserverBridge::OnAppListModelSigninStatusChanged() {
delegate_ ? delegate_->GetSigninDelegate() : NULL;
BOOL show_signin_view =
signinDelegate && ![appsGridController_ model]->signed_in();
- if (!!signinViewController_ == show_signin_view)
- return;
+
+ [[signinViewController_ view] removeFromSuperview];
+ signinViewController_.reset();
if (!show_signin_view) {
- [[signinViewController_ view] removeFromSuperview];
- signinViewController_.reset();
[backgroundView_ setHidden:NO];
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698