Issue 25649004: Always tear down the OSX app list signin view, when the signin status changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25649004: Always tear down the OSX app list signin view, when the signin status changes. (Closed)

Created:
7 years, 2 months ago by tapted

Modified:
7 years, 2 months ago

Reviewers:
calamity

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Always tear down the OSX app list signin view, when the signin status changes. This improves a fix in r218251, after which the signinDelegate on the signin view would not be replaced when the model changes, but when both models were signed out. BUG=297437 TEST=Have the OSX App Launcher enabled and a single, signed out profile. Delete the profile from chrome://settings, then click sign in on the app launcher. Chrome should not crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226443

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	ui/app_list/cocoa/app_list_view_controller.mm	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/25649004/1

7 years, 2 months ago (2013-10-02 06:45:31 UTC) #3

Message was sent while issue was closed.

Change committed as 226443

Expand Messages | Collapse Messages