Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart

Issue 2564863003: Get all integration tests running with the new driver (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart
diff --git a/pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart b/pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart
index bcfa73e034c1bc12c9497b313b6a5fbe5423edbd..2e1e77858b5e5aa98411aa25376f9313da53b433 100644
--- a/pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart
+++ b/pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library test.integration.search.domain;
-
import 'dart:async';
import 'package:analysis_server/plugin/protocol/protocol.dart';
@@ -14,57 +12,13 @@ import '../integration_tests.dart';
main() {
defineReflectiveSuite(() {
- defineReflectiveTests(Test);
+ defineReflectiveTests(GetTypeHierarchyTest);
+ defineReflectiveTests(GetTypeHierarchyTest_Driver);
});
}
-/**
- * Results of a getTypeHierarchy request, processed for easier testing.
- */
-class HierarchyResults {
- /**
- * The list of hierarchy items from the result.
- */
- List<TypeHierarchyItem> items;
-
- /**
- * The first hierarchy item from the result, which represents the pivot
- * class.
- */
- TypeHierarchyItem pivot;
-
- /**
- * A map from element name to item index.
- */
- Map<String, int> nameToIndex;
-
- /**
- * Create a [HierarchyResults] object based on the result from a
- * getTypeHierarchy request.
- */
- HierarchyResults(this.items) {
- pivot = items[0];
- nameToIndex = <String, int>{};
- for (int i = 0; i < items.length; i++) {
- nameToIndex[items[i].classElement.name] = i;
- }
- }
-
- /**
- * Get an item by class name.
- */
- TypeHierarchyItem getItem(String name) {
- if (nameToIndex.containsKey(name)) {
- return items[nameToIndex[name]];
- } else {
- fail('Class $name not found in hierarchy results');
- return null;
- }
- }
-}
-
-@reflectiveTest
-class Test extends AbstractAnalysisServerIntegrationTest {
+class AbstractGetTypeHierarchyTest
+ extends AbstractAnalysisServerIntegrationTest {
/**
* Pathname of the main file to run tests in.
*/
@@ -274,3 +228,57 @@ class Pivot /* target */ extends Base2 {}
}
}
}
+
+@reflectiveTest
+class GetTypeHierarchyTest extends AbstractGetTypeHierarchyTest {}
+
+@reflectiveTest
+class GetTypeHierarchyTest_Driver extends AbstractGetTypeHierarchyTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+}
+
+/**
+ * Results of a getTypeHierarchy request, processed for easier testing.
+ */
+class HierarchyResults {
+ /**
+ * The list of hierarchy items from the result.
+ */
+ List<TypeHierarchyItem> items;
+
+ /**
+ * The first hierarchy item from the result, which represents the pivot
+ * class.
+ */
+ TypeHierarchyItem pivot;
+
+ /**
+ * A map from element name to item index.
+ */
+ Map<String, int> nameToIndex;
+
+ /**
+ * Create a [HierarchyResults] object based on the result from a
+ * getTypeHierarchy request.
+ */
+ HierarchyResults(this.items) {
+ pivot = items[0];
+ nameToIndex = <String, int>{};
+ for (int i = 0; i < items.length; i++) {
+ nameToIndex[items[i].classElement.name] = i;
+ }
+ }
+
+ /**
+ * Get an item by class name.
+ */
+ TypeHierarchyItem getItem(String name) {
+ if (nameToIndex.containsKey(name)) {
+ return items[nameToIndex[name]];
+ } else {
+ fail('Class $name not found in hierarchy results');
+ return null;
+ }
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698