Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Unified Diff: pkg/analysis_server/test/integration/completion/get_suggestions_test.dart

Issue 2564863003: Get all integration tests running with the new driver (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/completion/get_suggestions_test.dart
diff --git a/pkg/analysis_server/test/integration/completion/get_suggestions_test.dart b/pkg/analysis_server/test/integration/completion/get_suggestions_test.dart
index 653711fc0c06f67c6621bd7daf50603b1c38361b..34b455b095a2f26aee1fce04346a4709fcbc9796 100644
--- a/pkg/analysis_server/test/integration/completion/get_suggestions_test.dart
+++ b/pkg/analysis_server/test/integration/completion/get_suggestions_test.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library test.integration.completion.get.suggestions;
-
import 'package:analysis_server/plugin/protocol/protocol.dart';
import 'package:test/test.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -12,12 +10,12 @@ import '../integration_tests.dart';
main() {
defineReflectiveSuite(() {
- defineReflectiveTests(Test);
+ defineReflectiveTests(GetSuggestionsTest);
+ defineReflectiveTests(GetSuggestionsTest_Driver);
});
}
-@reflectiveTest
-class Test extends AbstractAnalysisServerIntegrationTest {
+class AbstractGetSuggestionsTest extends AbstractAnalysisServerIntegrationTest {
String path;
String content;
int completionOffset;
@@ -123,3 +121,26 @@ main() {
});
}
}
+
+@reflectiveTest
+class GetSuggestionsTest extends AbstractGetSuggestionsTest {}
+
+@reflectiveTest
+class GetSuggestionsTest_Driver extends AbstractGetSuggestionsTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+
+ @failingTest
+ test_getSuggestions_onlyOverlay() async {
+ // TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
+ //return super.test_getSuggestions_onlyOverlay();
+ fail('Test timed out');
+ }
+
+ @failingTest
+ test_getSuggestions_sourceMissing_noWait() {
+ // Expected: same instance as 'exception from server'
+ // Actual: CompletionGetSuggestionsResult:<{"id":"0"}>
+ return super.test_getSuggestions_sourceMissing_noWait();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698