Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: pkg/analysis_server/test/integration/analysis/package_root_test.dart

Issue 2564863003: Get all integration tests running with the new driver (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis/package_root_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/package_root_test.dart b/pkg/analysis_server/test/integration/analysis/package_root_test.dart
index 5ad9c38e70d4bd074e350558662d7ef2a9dcdd67..142d50be795dca627f4414318055773fd6a528bc 100644
--- a/pkg/analysis_server/test/integration/analysis/package_root_test.dart
+++ b/pkg/analysis_server/test/integration/analysis/package_root_test.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library test.integration.analysis.packageRoot;
-
import 'package:analysis_server/plugin/protocol/protocol.dart';
import 'package:path/path.dart' as path;
import 'package:test/test.dart';
@@ -13,12 +11,13 @@ import '../integration_tests.dart';
main() {
defineReflectiveSuite(() {
- defineReflectiveTests(Test);
+ defineReflectiveTests(SetAnalysisRootsTest);
+ defineReflectiveTests(SetAnalysisRootsTest_Driver);
});
}
-@reflectiveTest
-class Test extends AbstractAnalysisServerIntegrationTest {
+class AbstractSetAnalysisRootsTest
+ extends AbstractAnalysisServerIntegrationTest {
test_package_root() {
String projPath = sourcePath('project');
String mainPath = path.join(projPath, 'main.dart');
@@ -77,3 +76,18 @@ f() {}
});
}
}
+
+@reflectiveTest
+class SetAnalysisRootsTest extends AbstractSetAnalysisRootsTest {}
+
+@reflectiveTest
+class SetAnalysisRootsTest_Driver extends AbstractSetAnalysisRootsTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+
+ @failingTest
+ test_package_root() {
+ // NoSuchMethodError: The getter 'iterator' was called on null.
+ return super.test_package_root();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698