Updateing ASAN stub with new API

Updateing ASAN stub with new API

Description:Updating ASAN stub with new API

Clang 3.4 added several ASAN functions and
it also changes the memory mapping for amd64.

BUG=chromium:303294
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227080

[yunlian, 2013-10-03 21:28:07]

Can you take a look at this CL.
This is blocking clang update for ChromeOS.
Thanks

[Nico, 2013-10-03 21:42:33]

lgtm

but kcc or samsonov should check the mappings (post-commit). The constants in
here look somewhat different from asan_mapping.h.

[Nico, 2013-10-03 21:42:54]

(kcc, samsonov: see previous comment)

[kcc1, 2013-10-04 04:49:19]

lgtm

LGTM

Please remember to be very careful with the stub and never link it to binaries
which we want to test.

[Alexander Potapenko, 2013-10-04 04:59:09]

LGTM
Nico, how can we make sure this stub isn't linked to the executables? In a
similar situation adding the corresponding target to the 'dependencies!'
section didn't work for me.
On Oct 4, 2013 8:49 AM, <kcc@google.com> wrote:

> lgtm
>
> LGTM
>
> Please remember to be very careful with the stub and never link it to
> binaries
> which we want to test.
>
>
https://codereview.chromium.**org/25648006/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-10-04 05:01:04]

On Thu, Oct 3, 2013 at 9:59 PM, Alexander Potapenko <glider@chromium.org>wrote:

> LGTM
> Nico, how can we make sure this stub isn't linked to the executables? In a
> similar situation adding the corresponding target to the 'dependencies!'
> section didn't work for me.
>
Some target needs this, right? So only the (linkable) targets that need
this should depend on it. Since only linkable targets will depend on it, it
won't be picked up by transitive dependencies.

Is there a concrete example you're worried about?


> On Oct 4, 2013 8:49 AM, <kcc@google.com> wrote:
>
>> lgtm
>>
>> LGTM
>>
>> Please remember to be very careful with the stub and never link it to
>> binaries
>> which we want to test.
>>
>>
https://codereview.chromium.**org/25648006/<https://codereview.chromium.org/2...
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[craigdh, 2013-10-04 16:01:12]

rubberstamp lgtm for OWNERS

[commit-bot: I haz the power, 2013-10-04 16:53:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yunlian@chromium.org/25648006/4001

[commit-bot: I haz the power, 2013-10-04 17:49:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yunlian@chromium.org/25648006/4001

[commit-bot: I haz the power, 2013-10-04 20:40:27]

Change committed as 227080