Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: third_party/WebKit/Source/core/css/PropertyRegistration.cpp

Issue 2564793002: Add smooth interpolation support for <color> custom properties (Closed)
Patch Set: <color> Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/PropertyRegistration.cpp
diff --git a/third_party/WebKit/Source/core/css/PropertyRegistration.cpp b/third_party/WebKit/Source/core/css/PropertyRegistration.cpp
index 5b7ee3b3d773e6b121fcd70207e40ca54819ae73..9b6ce0bb670d9941912d8b23a36899cae2674e5e 100644
--- a/third_party/WebKit/Source/core/css/PropertyRegistration.cpp
+++ b/third_party/WebKit/Source/core/css/PropertyRegistration.cpp
@@ -4,7 +4,6 @@
#include "core/css/PropertyRegistration.h"
-#include "core/animation/CSSValueInterpolationType.h"
#include "core/css/CSSSyntaxDescriptor.h"
#include "core/css/CSSValueList.h"
#include "core/css/CSSVariableReferenceValue.h"
@@ -57,17 +56,6 @@ static bool computationallyIndependent(const CSSValue& value) {
return true;
}
-InterpolationTypes interpolationTypesForSyntax(const AtomicString& propertyName,
- const CSSSyntaxDescriptor&) {
- PropertyHandle property(propertyName);
- InterpolationTypes interpolationTypes;
- // TODO(alancutter): Read the syntax descriptor and add the appropriate
- // CSSInterpolationType subclasses.
- interpolationTypes.append(
- WTF::makeUnique<CSSValueInterpolationType>(property));
- return interpolationTypes;
-}
-
void PropertyRegistration::registerProperty(
ExecutionContext* executionContext,
const PropertyDescriptor& descriptor,
@@ -102,7 +90,7 @@ void PropertyRegistration::registerProperty(
}
InterpolationTypes interpolationTypes =
- interpolationTypesForSyntax(atomicName, syntaxDescriptor);
+ syntaxDescriptor.createInterpolationTypes(atomicName);
if (descriptor.hasInitialValue()) {
CSSTokenizer tokenizer(descriptor.initialValue());

Powered by Google App Engine
This is Rietveld 408576698