Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2564763002:
Fix calculateCharacterSubrange() when length == 0 (Closed)
DescriptionFix calculateCharacterSubrange() when length == 0
When length == 0, it should return a collasped range instead of a range
with distance == 1.
This is pre-CL of https://codereview.chromium.org/2530843003/
BUG=620549
Committed: https://crrev.com/74eab98911047f5d59f89dddaeb412ea6f77718c
Cr-Commit-Position: refs/heads/master@{#437500}
Patch Set 1 #Patch Set 2 : Add a unit test #
Messages
Total messages: 25 (15 generated)
The CQ bit was checked by yabinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix calculateCharacterSubrange() when length == 0 When length == 0, it should return a collasped range instead of a range with distance == 1. This is pre-CL of https://codereview.chromium.org/2530843003/ BUG=620549 ========== to ========== Fix calculateCharacterSubrange() when length == 0 When length == 0, it should return a collasped range instead of a range with distance == 1. This is pre-CL of https://codereview.chromium.org/2530843003/ BUG=620549 ==========
yabinh@chromium.org changed reviewers: + aelias@chromium.org, changwan@chromium.org, xiaochengh@chromium.org, yosin@chromium.org
xiaochengh@chromium.org changed reviewers: + tkent@chromium.org
Non-owner's lgtm. Thanks for the patch! +tkent for owner's review since yosin is on vacation.
Can you add a unit test?
On 2016/12/09 06:36:44, tkent wrote: > Can you add a unit test? Where should we add the test? Do we need to add a new file like "CharacterIteratorTest.cpp"?
> Where should we add the test? Do we need to add a new file like "CharacterIteratorTest.cpp"? Right.
On 2016/12/09 at 06:39:46, tkent wrote: > > Where should we add the test? Do we need to add a new file like "CharacterIteratorTest.cpp"? > > Right. There is already editing/iterators/CharacterIteratorTest.cpp.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yabinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> There is already editing/iterators/CharacterIteratorTest.cpp. Yes. I didn't notice that. tkent@, PTAL.
lgtm
The CQ bit was unchecked by yabinh@chromium.org
The CQ bit was checked by yabinh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiaochengh@chromium.org Link to the patchset: https://codereview.chromium.org/2564763002/#ps20001 (title: "Add a unit test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481269629694360,
"parent_rev": "cae7c08c660ef9d5eabfa434d6ca93100f7df465", "commit_rev":
"f97cbb7c81ecd8f3c6c1538526a6f2ced85f3e45"}
Message was sent while issue was closed.
Description was changed from ========== Fix calculateCharacterSubrange() when length == 0 When length == 0, it should return a collasped range instead of a range with distance == 1. This is pre-CL of https://codereview.chromium.org/2530843003/ BUG=620549 ========== to ========== Fix calculateCharacterSubrange() when length == 0 When length == 0, it should return a collasped range instead of a range with distance == 1. This is pre-CL of https://codereview.chromium.org/2530843003/ BUG=620549 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix calculateCharacterSubrange() when length == 0 When length == 0, it should return a collasped range instead of a range with distance == 1. This is pre-CL of https://codereview.chromium.org/2530843003/ BUG=620549 ========== to ========== Fix calculateCharacterSubrange() when length == 0 When length == 0, it should return a collasped range instead of a range with distance == 1. This is pre-CL of https://codereview.chromium.org/2530843003/ BUG=620549 Committed: https://crrev.com/74eab98911047f5d59f89dddaeb412ea6f77718c Cr-Commit-Position: refs/heads/master@{#437500} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/74eab98911047f5d59f89dddaeb412ea6f77718c Cr-Commit-Position: refs/heads/master@{#437500} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
