Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2564733002: DevTools: [Search] do not search inside binary files. (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Search] do not search inside binary files. This patch skips binary UISourceCodes so that we don't search in them. BUG=585383 R=dgozman Committed: https://crrev.com/486b1f4872b106bebd2c970f433ee21fcfedb78a Cr-Commit-Position: refs/heads/master@{#437467}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
lushnikov
please, take a look
4 years ago (2016-12-09 00:10:39 UTC) #1
dgozman
lgtm
4 years ago (2016-12-09 01:27:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564733002/1
4 years ago (2016-12-09 01:28:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 04:38:27 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-09 04:40:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/486b1f4872b106bebd2c970f433ee21fcfedb78a
Cr-Commit-Position: refs/heads/master@{#437467}

Powered by Google App Engine
This is Rietveld 408576698