Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Issue 256473004: DevTools: handle Tracing.start in both browser and renderer (Closed)

Created:
6 years, 8 months ago by caseq
Modified:
6 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

DevTools: handle Tracing.start in both browser and renderer Do not return response from browser override for Tracing.start, so we invoke one in the renderer. For blink counterpart, see: https://codereview.chromium.org/254613002 BUG=361045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M content/browser/devtools/devtools_tracing_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
caseq
We now expect callback for Tracing.start() to be invoked from the back-end, when the tracing ...
6 years, 8 months ago (2014-04-24 11:54:39 UTC) #1
yurys
6 years, 8 months ago (2014-04-24 14:15:12 UTC) #2
yurys
lgtm
6 years, 8 months ago (2014-04-24 14:15:49 UTC) #3
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 7 months ago (2014-04-29 11:27:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/256473004/1
6 years, 7 months ago (2014-04-29 11:28:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 11:53:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium
6 years, 7 months ago (2014-04-29 11:53:49 UTC) #7
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 7 months ago (2014-04-29 16:02:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/256473004/1
6 years, 7 months ago (2014-04-29 16:03:28 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:06:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:06:57 UTC) #11
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 7 months ago (2014-04-30 07:55:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/256473004/1
6 years, 7 months ago (2014-04-30 07:55:29 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 07:58:59 UTC) #14
Message was sent while issue was closed.
Change committed as 267126

Powered by Google App Engine
This is Rietveld 408576698