Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2564703002: CSS Motion Path: Deprecate motion-* and offset-rotation (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 3369b6a7ed3c0813580b52962b9ed228f3104b37..6284adb2f49a04c4558cb2123b68384e1e86d812 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -54,8 +54,6 @@ String willBeRemoved(const char* feature,
feature, milestoneString(milestone), details);
}
-#if 0
-// TODO(jsbell): Currently unused, but likely to be needed in the future.
String replacedWillBeRemoved(const char* feature,
const char* replacement,
Milestone milestone,
@@ -65,7 +63,6 @@ String replacedWillBeRemoved(const char* feature,
"https://www.chromestatus.com/features/%s for more details.",
feature, milestoneString(milestone), replacement, details);
}
-#endif
} // anonymous namespace
@@ -116,10 +113,25 @@ void Deprecation::warnOnDeprecatedProperties(const LocalFrame* frame,
}
String Deprecation::deprecationMessage(CSSPropertyID unresolvedProperty) {
- // TODO: Add a switch here when there are properties that we intend to
- // deprecate.
- // Returning an empty string for now.
- return emptyString();
+ switch (unresolvedProperty) {
+ case CSSPropertyAliasMotionOffset:
+ return replacedWillBeRemoved("motion-offset", "offset-distance", M58,
+ "6390764217040896");
+ case CSSPropertyAliasMotionRotation:
+ return replacedWillBeRemoved("motion-rotation", "offset-rotate", M58,
+ "6390764217040896");
+ case CSSPropertyAliasMotionPath:
+ return replacedWillBeRemoved("motion-path", "offset-path", M58,
+ "6390764217040896");
+ case CSSPropertyMotion:
+ return replacedWillBeRemoved("motion", "offset", M58, "6390764217040896");
+ case CSSPropertyOffsetRotation:
+ return replacedWillBeRemoved("offset-rotation", "offset-rotate", M58,
+ "6390764217040896");
+
+ default:
+ return emptyString();
+ }
}
void Deprecation::countDeprecation(const LocalFrame* frame,
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698