Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2564703002: CSS Motion Path: Deprecate motion-* and offset-rotation (Closed)

Created:
4 years ago by Eric Willigers
Modified:
4 years ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Motion Path: Deprecate motion-* and offset-rotation The motion* deprecations were temporarily removed, until offset-rotate was available. We now enable them again. motion-path becomes offset-path motion-offset becomes offset-distance motion-rotation becomes offset-rotate motion becomes motion-path We also add a new deprecation: offset-rotation becomes offset-rotate BUG=669782, 672264 Committed: https://crrev.com/f8be9028bcafa8722452bf454d11b2dc6304f0f8 Cr-Commit-Position: refs/heads/master@{#437461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -25 lines) Patch
A third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset-rotation-deprecated.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset-rotation-deprecated-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 3 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Eric Willigers
4 years ago (2016-12-08 23:35:58 UTC) #3
sashab
lgtm
4 years ago (2016-12-08 23:37:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564703002/1
4 years ago (2016-12-09 04:00:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 04:16:43 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-09 04:19:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8be9028bcafa8722452bf454d11b2dc6304f0f8
Cr-Commit-Position: refs/heads/master@{#437461}

Powered by Google App Engine
This is Rietveld 408576698