Silence narrowing warning with XRectangle

Silence narrowing warning with XRectangle

XRectangle is defined as such in <X11/Xlib.h>:

typedef struct {
    short x, y;
    unsigned short width, height;
} XRectangle;

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227083

[philipj_slow, 2013-10-04 08:36:12]

Hi Elliot, look what happens when you point me at linux_aura :)

[philipj_slow, 2013-10-04 09:09:18]

Please ignore the trybots, I was just testing to see if I could start them, but
it looks like I need to request trybot access.

[Elliot Glaysher, 2013-10-04 17:48:41]

lgtm

1) Please put "BUG=none" instead of "BUG=".

2) What compiler are you using? I didn't get any narrowing errors on my machine,
the trybots or the waterfall.

[commit-bot: I haz the power, 2013-10-04 17:49:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/25647004/1

[commit-bot: I haz the power, 2013-10-04 20:52:30]

Change committed as 227083

[philipj_slow, 2013-10-04 20:52:47]

On 2013/10/04 17:48:41, Elliot Glaysher wrote:
> lgtm
> 
> 1) Please put "BUG=none" instead of "BUG=".

Thanks, will do!

> 2) What compiler are you using? I didn't get any narrowing errors on my
machine,
> the trybots or the waterfall.

This was using GCC 4.7.3 on Ubuntu. These were the warnings:

../../ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc: In member
function 'void views::DesktopRootWindowHostX11::ResetWindowRegion()':
../../ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc:1056:40:
error: narrowing conversion of
'((views::DesktopRootWindowHostX11*)this)->views::DesktopRootWindowHostX11::bounds_.gfx::Rect::<anonymous>.gfx::RectBase<Class,
PointClass, SizeClass, InsetsClass, VectorClass, Type>::width<gfx::Rect,
gfx::Point, gfx::Size, gfx::Insets, gfx::Vector2d, int>()' from 'int' to 'short
unsigned int' inside { } is ill-formed in C++11 [-Werror=narrowing]
../../ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc:1056:58:
error: narrowing conversion of
'((views::DesktopRootWindowHostX11*)this)->views::DesktopRootWindowHostX11::bounds_.gfx::Rect::<anonymous>.gfx::RectBase<Class,
PointClass, SizeClass, InsetsClass, VectorClass, Type>::height<gfx::Rect,
gfx::Point, gfx::Size, gfx::Insets, gfx::Vector2d, int>()' from 'int' to 'short
unsigned int' inside { } is ill-formed in C++11 [-Werror=narrowing]

[Elliot Glaysher, 2013-10-04 20:58:31]

On 2013/10/04 20:52:47, philipj wrote:
> This was using GCC 4.7.3 on Ubuntu. These were the warnings:

You're off the beaten path. We compile either with gcc 4.6.3 (the one installed
on the Ubuntu LTS) or the bundled version of clang.

> ../../ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc: In member
> function 'void views::DesktopRootWindowHostX11::ResetWindowRegion()':
> ../../ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc:1056:40:
> error: narrowing conversion of
>
'((views::DesktopRootWindowHostX11*)this)->views::DesktopRootWindowHostX11::bounds_.gfx::Rect::<anonymous>.gfx::RectBase<Class,
> PointClass, SizeClass, InsetsClass, VectorClass, Type>::width<gfx::Rect,
> gfx::Point, gfx::Size, gfx::Insets, gfx::Vector2d, int>()' from 'int' to
'short
> unsigned int' inside { } is ill-formed in C++11 [-Werror=narrowing]

It would probably be better to figure out why the narrowing warning is enabled,
as IIRC, we disable that warning in gyp.

[philipj_slow, 2013-10-04 21:10:44]

On 2013/10/04 20:58:31, Elliot Glaysher wrote:
> On 2013/10/04 20:52:47, philipj wrote:
> > This was using GCC 4.7.3 on Ubuntu. These were the warnings:
> 
> You're off the beaten path. We compile either with gcc 4.6.3 (the one
installed
> on the Ubuntu LTS) or the bundled version of clang.

Huh, I wasn't aware that there was a beaten path :) I'm using Ubuntu 13.04. I
could build Chromium with gcc 4.6, but don't mind fixing compiler warnings if
the reviewers don't.

> > ../../ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc: In
member
> > function 'void views::DesktopRootWindowHostX11::ResetWindowRegion()':
> > ../../ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc:1056:40:
> > error: narrowing conversion of
> >
>
'((views::DesktopRootWindowHostX11*)this)->views::DesktopRootWindowHostX11::bounds_.gfx::Rect::<anonymous>.gfx::RectBase<Class,
> > PointClass, SizeClass, InsetsClass, VectorClass, Type>::width<gfx::Rect,
> > gfx::Point, gfx::Size, gfx::Insets, gfx::Vector2d, int>()' from 'int' to
> 'short
> > unsigned int' inside { } is ill-formed in C++11 [-Werror=narrowing]
> 
> It would probably be better to figure out why the narrowing warning is
enabled,
> as IIRC, we disable that warning in gyp.

I see -Wno-c++11-narrowing in build/common.gypi and -Wno-narrowing in
webkit/glue/webkit_glue.gypi, so I guess this warning wasn't disabled by
-Wno-c++11-narrowing, it does just say [-Werror=narrowing] after all.

[philipj_slow, 2013-10-07 08:33:33]

I was curious, so I took another look, and it turns out that
-Wno-c++11-narrowing is just for clang, so it's simply the case that gcc 4.7
warns for this where gcc 4.6 did not.