Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 2564693002: Make virtual method pure virtual (Closed)

Created:
4 years ago by sgurun-gerrit only
Modified:
4 years ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make virtual method pure virtual It seems method implementation does not exist but method is not declared as pure virtual. Committed: https://crrev.com/d8244df22299cee8a52451031abf3254902cbd44 Cr-Commit-Position: refs/heads/master@{#437403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/browser/compositor_frame_consumer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sgurun-gerrit only
On 2016/12/08 23:26:28, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:boliu@chromium.org ptal
4 years ago (2016-12-08 23:26:35 UTC) #3
boliu
lgtm
4 years ago (2016-12-08 23:36:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564693002/1
4 years ago (2016-12-08 23:58:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 01:19:00 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-09 01:20:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8244df22299cee8a52451031abf3254902cbd44
Cr-Commit-Position: refs/heads/master@{#437403}

Powered by Google App Engine
This is Rietveld 408576698