Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: content/public/browser/screen_orientation_provider.h

Issue 2564653003: [DeviceService] Move screen_orientation.mojom from //content to //device. (Closed)
Patch Set: Move screen_orientation_lock_types.mojom from blink into //device Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/screen_orientation_provider.h
diff --git a/content/public/browser/screen_orientation_provider.h b/content/public/browser/screen_orientation_provider.h
index f5d0f229b427fd04ad8eb7a04be7f8ca78ab96aa..83b329fe43105641c39b75d81d462b74868ea645 100644
--- a/content/public/browser/screen_orientation_provider.h
+++ b/content/public/browser/screen_orientation_provider.h
@@ -11,8 +11,8 @@
#include "base/macros.h"
#include "content/common/content_export.h"
#include "content/public/browser/web_contents_observer.h"
+#include "device/screen_orientation/public/interfaces/screen_orientation_lock_types.mojom.h"
#include "third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationLockType.h"
-#include "third_party/WebKit/public/platform/modules/screen_orientation/screen_orientation_lock_types.mojom.h"
namespace content {
@@ -20,7 +20,7 @@ class ScreenOrientationDelegate;
class WebContents;
using LockOrientationCallback =
- base::Callback<void(::blink::mojom::ScreenOrientationLockResult)>;
+ base::Callback<void(::device::mojom::ScreenOrientationLockResult)>;
// Handles screen orientation lock/unlock. Platforms which wish to provide
// custom implementations can provide a factory for ScreenOrientationDelegate.
@@ -53,7 +53,7 @@ class CONTENT_EXPORT ScreenOrientationProvider : public WebContentsObserver {
private:
// Calls on |on_result_callback_| with |result|, followed by resetting
// |on_result_callback_| and |pending_lock_orientation_|.
- void NotifyLockResult(::blink::mojom::ScreenOrientationLockResult result);
+ void NotifyLockResult(::device::mojom::ScreenOrientationLockResult result);
blundell 2016/12/12 12:30:46 tiny nit: the leading :: shouldn't be necessary he
leonhsl(Using Gerrit) 2016/12/13 03:39:58 Done.
// Returns the lock type that should be associated with 'natural' lock.
// Returns WebScreenOrientationLockDefault if the natural lock type can't be

Powered by Google App Engine
This is Rietveld 408576698