Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Add new layout tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 9887dd87987013fc175e43088aac32a9681f2f31..86ca04d9680204ed949cb92b928e84a4821b1aca 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1590,7 +1590,8 @@ LocalFrame* WebLocalFrameImpl::createChildFrame(
WebFrameOwnerProperties ownerProperties(
ownerElement->scrollingMode(), ownerElement->marginWidth(),
ownerElement->marginHeight(), ownerElement->allowFullscreen(),
- ownerElement->csp(), ownerElement->delegatedPermissions());
+ ownerElement->isDisplayNone(), ownerElement->csp(),
+ ownerElement->delegatedPermissions());
// FIXME: Using subResourceAttributeName as fallback is not a perfect
// solution. subResourceAttributeName returns just one attribute name. The
// element might not have the attribute, and there might be other attributes

Powered by Google App Engine
This is Rietveld 408576698