Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1586 matching lines...) Expand 10 before | Expand all | Expand 10 after
1597 HTMLFrameOwnerElement* ownerElement) { 1597 HTMLFrameOwnerElement* ownerElement) {
1598 DCHECK(m_client); 1598 DCHECK(m_client);
1599 TRACE_EVENT0("blink", "WebLocalFrameImpl::createChildframe"); 1599 TRACE_EVENT0("blink", "WebLocalFrameImpl::createChildframe");
1600 WebTreeScopeType scope = frame()->document() == ownerElement->treeScope() 1600 WebTreeScopeType scope = frame()->document() == ownerElement->treeScope()
1601 ? WebTreeScopeType::Document 1601 ? WebTreeScopeType::Document
1602 : WebTreeScopeType::Shadow; 1602 : WebTreeScopeType::Shadow;
1603 WebFrameOwnerProperties ownerProperties( 1603 WebFrameOwnerProperties ownerProperties(
1604 ownerElement->browsingContextContainerName(), 1604 ownerElement->browsingContextContainerName(),
1605 ownerElement->scrollingMode(), ownerElement->marginWidth(), 1605 ownerElement->scrollingMode(), ownerElement->marginWidth(),
1606 ownerElement->marginHeight(), ownerElement->allowFullscreen(), 1606 ownerElement->marginHeight(), ownerElement->allowFullscreen(),
1607 ownerElement->allowPaymentRequest(), ownerElement->csp(), 1607 ownerElement->allowPaymentRequest(), ownerElement->isDisplayNone(),
1608 ownerElement->delegatedPermissions()); 1608 ownerElement->csp(), ownerElement->delegatedPermissions());
1609 // FIXME: Using subResourceAttributeName as fallback is not a perfect 1609 // FIXME: Using subResourceAttributeName as fallback is not a perfect
1610 // solution. subResourceAttributeName returns just one attribute name. The 1610 // solution. subResourceAttributeName returns just one attribute name. The
1611 // element might not have the attribute, and there might be other attributes 1611 // element might not have the attribute, and there might be other attributes
1612 // which can identify the element. 1612 // which can identify the element.
1613 AtomicString uniqueName = frame()->tree().calculateUniqueNameForNewChildFrame( 1613 AtomicString uniqueName = frame()->tree().calculateUniqueNameForNewChildFrame(
1614 name, 1614 name,
1615 ownerElement->getAttribute(ownerElement->subResourceAttributeName())); 1615 ownerElement->getAttribute(ownerElement->subResourceAttributeName()));
1616 WebLocalFrameImpl* webframeChild = 1616 WebLocalFrameImpl* webframeChild =
1617 toWebLocalFrameImpl(m_client->createChildFrame( 1617 toWebLocalFrameImpl(m_client->createChildFrame(
1618 this, scope, name, uniqueName, 1618 this, scope, name, uniqueName,
(...skipping 758 matching lines...) Expand 10 before | Expand all | Expand 10 after
2377 ->frameScheduler() 2377 ->frameScheduler()
2378 ->unthrottledTaskRunner() 2378 ->unthrottledTaskRunner()
2379 ->toSingleThreadTaskRunner(); 2379 ->toSingleThreadTaskRunner();
2380 } 2380 }
2381 2381
2382 WebInputMethodControllerImpl* WebLocalFrameImpl::inputMethodController() const { 2382 WebInputMethodControllerImpl* WebLocalFrameImpl::inputMethodController() const {
2383 return m_inputMethodController.get(); 2383 return m_inputMethodController.get();
2384 } 2384 }
2385 2385
2386 } // namespace blink 2386 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698