Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Comments from esprehn. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 void clearContentFrame() override; 80 void clearContentFrame() override;
81 void dispatchLoad() override; 81 void dispatchLoad() override;
82 SandboxFlags getSandboxFlags() const override { return m_sandboxFlags; } 82 SandboxFlags getSandboxFlags() const override { return m_sandboxFlags; }
83 bool canRenderFallbackContent() const override { return false; } 83 bool canRenderFallbackContent() const override { return false; }
84 void renderFallbackContent() override {} 84 void renderFallbackContent() override {}
85 ScrollbarMode scrollingMode() const override { return ScrollbarAuto; } 85 ScrollbarMode scrollingMode() const override { return ScrollbarAuto; }
86 int marginWidth() const override { return -1; } 86 int marginWidth() const override { return -1; }
87 int marginHeight() const override { return -1; } 87 int marginHeight() const override { return -1; }
88 bool allowFullscreen() const override { return false; } 88 bool allowFullscreen() const override { return false; }
89 bool allowPaymentRequest() const override { return false; } 89 bool allowPaymentRequest() const override { return false; }
90 bool isDisplayNone() const override { return !m_widget; }
90 AtomicString csp() const override { return nullAtom; } 91 AtomicString csp() const override { return nullAtom; }
91 const WebVector<WebPermissionType>& delegatedPermissions() const override; 92 const WebVector<WebPermissionType>& delegatedPermissions() const override;
92 93
93 DECLARE_VIRTUAL_TRACE(); 94 DECLARE_VIRTUAL_TRACE();
94 95
95 protected: 96 protected:
96 HTMLFrameOwnerElement(const QualifiedName& tagName, Document&); 97 HTMLFrameOwnerElement(const QualifiedName& tagName, Document&);
97 void setSandboxFlags(SandboxFlags); 98 void setSandboxFlags(SandboxFlags);
98 99
99 bool loadOrRedirectSubframe(const KURL&, 100 bool loadOrRedirectSubframe(const KURL&,
100 const AtomicString& frameName, 101 const AtomicString& frameName,
101 bool replaceCurrentItem); 102 bool replaceCurrentItem);
102 bool isKeyboardFocusable() const override; 103 bool isKeyboardFocusable() const override;
103 104
104 void disposeWidgetSoon(Widget*); 105 void disposeWidgetSoon(Widget*);
106 void frameOwnerPropertiesChanged();
105 107
106 private: 108 private:
107 // Intentionally private to prevent redundant checks when the type is 109 // Intentionally private to prevent redundant checks when the type is
108 // already HTMLFrameOwnerElement. 110 // already HTMLFrameOwnerElement.
109 bool isLocal() const override { return true; } 111 bool isLocal() const override { return true; }
110 bool isRemote() const override { return false; } 112 bool isRemote() const override { return false; }
111 113
112 bool isFrameOwnerElement() const final { return true; } 114 bool isFrameOwnerElement() const final { return true; }
113 115
114 virtual ReferrerPolicy referrerPolicyAttribute() { 116 virtual ReferrerPolicy referrerPolicyAttribute() {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 159
158 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement, 160 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement,
159 FrameOwner, 161 FrameOwner,
160 owner, 162 owner,
161 owner->isLocal(), 163 owner->isLocal(),
162 owner.isLocal()); 164 owner.isLocal());
163 165
164 } // namespace blink 166 } // namespace blink
165 167
166 #endif // HTMLFrameOwnerElement_h 168 #endif // HTMLFrameOwnerElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698