Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2564623003: Add optional message argument to assert statements in the VM. (Closed)

Created:
4 years ago by hausner
Modified:
4 years ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add optional message argument to assert statements in the VM. Add flag --assert-message to control the feature. Fixes issue #24215 BUG= http://dartbug.com/24215 This replaces Lasse’s CL 1307363005 patch from issue 1307363005 at patchset 140001 (http://crrev.com/1307363005#ps140001) R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/67e83dd79d1e8b58ef5a73dcf7cfc2fb22b108b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -30 lines) Patch
M runtime/lib/errors.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M runtime/lib/errors_patch.dart View 3 chunks +20 lines, -17 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 3 chunks +41 lines, -7 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/errors.dart View 1 chunk +3 lines, -1 line 0 comments Download
A tests/language/assert_message_test.dart View 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years ago (2016-12-09 01:00:05 UTC) #3
Lasse Reichstein Nielsen
LGTM if the test runs :) We'll probably remove (or at least toggle) the flag ...
4 years ago (2016-12-09 07:50:17 UTC) #4
hausner
4 years ago (2016-12-09 17:26:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
67e83dd79d1e8b58ef5a73dcf7cfc2fb22b108b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698