[Mac] RTL-aware drawing and animation for the content settings decoration

[Mac] RTL-aware drawing and animation for the content settings decoration

BUG=648557
Committed: https://crrev.com/24cb108d6ed64df2a989b99c609193c6ab67393f
Cr-Commit-Position: refs/heads/master@{#437301}

[lgrey, 2016-12-08 17:01:35]

lgrey@chromium.org changed reviewers:
+ ellyjones@chromium.org

[lgrey, 2016-12-08 17:01:36]

PTAL :)

NB: This isn't going to look right until the forthcoming CL that reverses the
order of the decorations lands. Pretend it's on the left :D

[Elly Fong-Jones, 2016-12-08 17:21:47]

lgtm

[lgrey, 2016-12-08 17:26:13]

lgrey@chromium.org changed reviewers:
+ mark@chromium.org

[lgrey, 2016-12-08 17:26:14]

Thanks!

+mark@ for OWNERS

[Mark Mentovai, 2016-12-08 17:37:48]

LGTM

https://codereview.chromium.org/2564593002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right):

https://codereview.chromium.org/2564593002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:388: if
(is_rtl)
Style wants {braces} on all parts of the construct if any part of an if or
if-else or if-else if-…-else is more than a line long.
https://google.github.io/styleguide/cppguide.html#Conditionals

[lgrey, 2016-12-08 18:19:36]

Thanks!

https://codereview.chromium.org/2564593002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right):

https://codereview.chromium.org/2564593002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:388: if
(is_rtl)
On 2016/12/08 17:37:48, Mark Mentovai wrote:
> Style wants {braces} on all parts of the construct if any part of an if or
> if-else or if-else if-…-else is more than a line long.
> https://google.github.io/styleguide/cppguide.html#Conditionals

Done.

[lgrey, 2016-12-08 18:19:39]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2016-12-08 18:19:39]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2564593002/#ps40001
(title: "If brackets")

[commit-bot: I haz the power, 2016-12-08 18:20:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 19:13:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481221179288950,
"parent_rev": "0de094f8d4a410d3212e1e9b57a3fb2bae43ee0d", "commit_rev":
"a979bf8f29ae301ad54c731c33de3743d55921b3"}

[commit-bot: I haz the power, 2016-12-08 19:13:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-08 19:17:18]

Description was changed from

==========
[Mac] RTL-aware drawing and animation for the content settings decoration

BUG=648557
==========

to

==========
[Mac] RTL-aware drawing and animation for the content settings decoration

BUG=648557

Committed: https://crrev.com/24cb108d6ed64df2a989b99c609193c6ab67393f
Cr-Commit-Position: refs/heads/master@{#437301}
==========

[commit-bot: I haz the power, 2016-12-08 19:17:18]

Patchset 3 (id:??) landed as
https://crrev.com/24cb108d6ed64df2a989b99c609193c6ab67393f
Cr-Commit-Position: refs/heads/master@{#437301}