Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2564593002: [Mac] RTL-aware drawing and animation for the content settings decoration (Closed)

Created:
4 years ago by lgrey
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] RTL-aware drawing and animation for the content settings decoration BUG=648557 Committed: https://crrev.com/24cb108d6ed64df2a989b99c609193c6ab67393f Cr-Commit-Position: refs/heads/master@{#437301}

Patch Set 1 #

Patch Set 2 : Restore accidentally deleted whitespace #

Total comments: 2

Patch Set 3 : If brackets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 2 3 chunks +39 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
lgrey
PTAL :) NB: This isn't going to look right until the forthcoming CL that reverses ...
4 years ago (2016-12-08 17:01:36 UTC) #2
Elly Fong-Jones
lgtm
4 years ago (2016-12-08 17:21:47 UTC) #3
lgrey
Thanks! +mark@ for OWNERS
4 years ago (2016-12-08 17:26:14 UTC) #5
Mark Mentovai
LGTM https://codereview.chromium.org/2564593002/diff/20001/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right): https://codereview.chromium.org/2564593002/diff/20001/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm#newcode388 chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:388: if (is_rtl) Style wants {braces} on all parts ...
4 years ago (2016-12-08 17:37:48 UTC) #6
lgrey
Thanks! https://codereview.chromium.org/2564593002/diff/20001/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right): https://codereview.chromium.org/2564593002/diff/20001/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm#newcode388 chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:388: if (is_rtl) On 2016/12/08 17:37:48, Mark Mentovai wrote: ...
4 years ago (2016-12-08 18:19:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564593002/40001
4 years ago (2016-12-08 18:20:17 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 19:13:52 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-08 19:17:18 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/24cb108d6ed64df2a989b99c609193c6ab67393f
Cr-Commit-Position: refs/heads/master@{#437301}

Powered by Google App Engine
This is Rietveld 408576698