sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart - Issue 256453004: Avoid inlining constants that are used via a deferred import.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

Issue 256453004: Avoid inlining constants that are used via a deferred import. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/nodes.dart ('k') | tests/compiler/dart2js/deferred_dont_inline_deferred_constants_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart b/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

index f8dcf42c09fe92fafc134aed095959b6c5cd3339..f58002930542c2b2d5ecb7d53e5696386a7f60cf 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

@@ -670,9 +670,15 @@ class SsaValueRangeAnalyzer extends HBaseVisitor implements OptimizationPhase {

return range;

}

- Range visitConstant(HConstant constant) {

- if (!constant.isInteger(compiler)) return info.newUnboundRange();

- NumConstant constantNum = constant.constant;

+ Range visitConstant(HConstant hConstant) {

+ if (!hConstant.isInteger(compiler)) return info.newUnboundRange();

+ Constant constant = hConstant.constant;

+ NumConstant constantNum;

+ if (constant is DeferredConstant) {

+ constantNum = constant.referenced;

+ } else {

+ constantNum = constant;

+ }

if (constantNum.isMinusZero) constantNum = new IntConstant(0);

Value value = info.newIntValue(constantNum.value);

return info.newNormalizedRange(value, value);