sdk/lib/_internal/compiler/implementation/deferred_load.dart - Issue 256453004: Avoid inlining constants that are used via a deferred import.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/deferred_load.dart

Issue 256453004: Avoid inlining constants that are used via a deferred import. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart2jslib.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/deferred_load.dart

diff --git a/sdk/lib/_internal/compiler/implementation/deferred_load.dart b/sdk/lib/_internal/compiler/implementation/deferred_load.dart

index b12ec4bb99e2f5bc45da00597f14565695d9cc3a..ba055a7c598652184bce7340fd536c10d11af778 100644

--- a/sdk/lib/_internal/compiler/implementation/deferred_load.dart

+++ b/sdk/lib/_internal/compiler/implementation/deferred_load.dart

@@ -11,6 +11,7 @@ import 'dart2jslib.dart' show

Constant,

ConstructedConstant,

MessageKind,

+ DeferredConstant,

StringConstant,

invariant;

@@ -189,6 +190,13 @@ class DeferredLoadTask extends CompilerTask {

return outputUnitForElement(e1) == outputUnitForElement(e2);

}

+ void registerConstantDeferredUse(DeferredConstant constant,

+ PrefixElement prefix) {

+ OutputUnit outputUnit = new OutputUnit();

+ outputUnit.imports.add(prefix.deferredImport);

+ _constantToOutputUnit[constant] = outputUnit;

+ }

/// Mark that [import] is part of the [OutputputUnit] for [element].

///

/// [element] can be either a [Constant] or an [Element].