sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 256453004: Avoid inlining constants that are used via a deferred import.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 256453004: Avoid inlining constants that are used via a deferred import. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use intermediate constants. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

index ad006f8a43bc919bfeccba29bd739bc6395bd0eb..2476e29d59b8e56760fed9f692451d5e5f6f35d4 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

@@ -184,6 +184,13 @@ class HGraph {

return result;

}

+ HConstant addDeferredConstant(Constant constant, PrefixElement prefix, Compiler compiler) {

Johnni Winther 2014/04/28 11:58:31 Long line.

sigurdm 2014/04/28 12:07:48 Done.

+ Constant wrapper = new DeferredConstant(constant,

+ prefix);

Johnni Winther 2014/04/28 11:58:31 Put this on one line.

sigurdm 2014/04/28 12:07:48 Done.

+ compiler.deferredLoadTask.registerConstantDeferredUse(wrapper, prefix);

+ return addConstant(wrapper, compiler);

+ }

HConstant addConstantInt(int i, Compiler compiler) {

return addConstant(compiler.backend.constantSystem.createInt(i), compiler);

}