Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/webshare/share_service_impl.h

Issue 2564483003: Default share to Share Target: Partial impl. of Web Share for Desktop. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/webshare/share_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webshare/share_service_impl.h
diff --git a/chrome/browser/webshare/share_service_impl.h b/chrome/browser/webshare/share_service_impl.h
index 83de10f9511ff36394283b8f200f331ae0dad769..8bd381f7c97df971ee70604a7804d264e6aad7ef 100644
--- a/chrome/browser/webshare/share_service_impl.h
+++ b/chrome/browser/webshare/share_service_impl.h
@@ -7,6 +7,7 @@
#include <string>
+#include "base/gtest_prod_util.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "third_party/WebKit/public/platform/modules/webshare/webshare.mojom.h"
@@ -20,12 +21,33 @@ class ShareServiceImpl : public blink::mojom::ShareService {
static void Create(mojo::InterfaceRequest<ShareService> request);
+ // blink::mojom::ShareService overrides:
void Share(const std::string& title,
const std::string& text,
- const GURL& url,
+ const GURL& share_url,
const ShareCallback& callback) override;
private:
+ FRIEND_TEST_ALL_PREFIXES(ShareServiceImplUnittest, ReplacePlaceholders);
+
+ // Opens a new tab and navigates to |target_url|.
+ // Virtual for testing purposes.
+ virtual void OpenTargetURL(const GURL& target_url);
+
+ // Writes to |url_template_filled|, a copy of |url_template| with all
+ // instances of "{title}", "{text}", and "{url}" replaced with
+ // |title|, |text|, and |url| respectively.
+ // Replaces instances of "{X}" where "X" is any string besides "title",
+ // "text", and "url", with an empty string, for forwards compatibility.
+ // Returns false, if there are badly nested placeholders.
+ // This includes any case in which two "{" occur before a "}", or a "}"
+ // occurs with no preceding "{".
+ static bool ReplacePlaceholders(base::StringPiece url_template,
+ base::StringPiece title,
+ base::StringPiece text,
+ const GURL& share_url,
+ std::string* url_template_filled);
+
DISALLOW_COPY_AND_ASSIGN(ShareServiceImpl);
};
« no previous file with comments | « no previous file | chrome/browser/webshare/share_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698