Default share to Share Target: Partial impl. of Web Share for Desktop.

chrome/browser/webshare/share_service_impl.h

Index: chrome/browser/webshare/share_service_impl.h
diff --git a/chrome/browser/webshare/share_service_impl.h b/chrome/browser/webshare/share_service_impl.h
index 83de10f9511ff36394283b8f200f331ae0dad769..45947b85673e3a7c17d53acde4e5eafab97148dc 100644
--- a/chrome/browser/webshare/share_service_impl.h
+++ b/chrome/browser/webshare/share_service_impl.h
@@ -7,6 +7,7 @@
 
 #include <string>
 
+#include "base/gtest_prod_util.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
 #include "third_party/WebKit/public/platform/modules/webshare/webshare.mojom.h"
 
@@ -20,12 +21,36 @@ class ShareServiceImpl : public blink::mojom::ShareService {
 
   static void Create(mojo::InterfaceRequest<ShareService> request);
 
+  // blink::mojom::ShareService overrides:
   void Share(const std::string& title,
              const std::string& text,
-             const GURL& url,
+             const GURL& share_url,
              const ShareCallback& callback) override;
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(ShareServiceImplUnittest, ReplacePlaceholders);
+
+  // Opens a new tab and navigates to |target_url|.
+  // Virtual for testing purposes.
+  virtual void OpenTargetURL(const GURL& target_url);
+
+  // static bool SplitTemplate(const std::string& url_template,

[Sam McNally, 2017/01/10 06:53:50]

Remove.

[constantina, 2017/01/12 04:04:41]

Done.

+  // std::vector<base::StringPiece>& split_template);
+
+  // Writes to |url_template_filled|, a copy of |url_template| with all
+  // instances of "{title}", "{text}", and "{url}" replaced with
+  // |title|, |text|, and |url| respectively.
+  // Replaces instances of "{X}" where "X" is any string besides "title",
+  // "text", and "url", with an empty string, for forwards compatibility.
+  // Returns false, if there are badly nested placeholders.
+  // This includes any case in which two "{" occur before a "}", or a "}"
+  // occurs with no preceding "{".
+  static bool ReplacePlaceholders(const std::string& url_template,

[Sam McNally, 2017/01/10 06:53:50]

StringPiece.

[constantina, 2017/01/12 04:04:41]

Done.

+                                  const std::string& title,
+                                  const std::string& text,
+                                  const GURL& share_url,
+                                  std::string* url_template_filled);
+
   DISALLOW_COPY_AND_ASSIGN(ShareServiceImpl);
 };