Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js

Issue 2564433004: DevTools: migrate last usages of samllIcons.png to UI.Icon (Closed)
Patch Set: rebaseline Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js
index f56fdaa3b88a092616a7451cb62892b9f3d2608a..6f50e907782da7bd01f11823322efb6a51e57f87 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js
@@ -176,6 +176,11 @@ Accessibility.AXNodeTreeElement = class extends TreeElement {
*/
setInspected(inspected) {
this._inspected = inspected;
+ if (this._inspected)
+ this.setTrailingIcons([UI.Icon.create('smallicon-thick-left-arrow')]);
+ else
+ this.setTrailingIcons([]);
+
this.listItemElement.classList.toggle('inspected', this._inspected);
}
@@ -211,28 +216,28 @@ Accessibility.AXNodeTreeElement = class extends TreeElement {
}
_update() {
- this.listItemElement.removeChildren();
+ this.titleElement().removeChildren();
if (this._axNode.ignored()) {
this._appendIgnoredNodeElement();
} else {
this._appendRoleElement(this._axNode.role());
if (this._axNode.name().value) {
- this.listItemElement.createChild('span', 'separator').textContent = '\u00A0';
+ this.titleElement().createChild('span', 'separator').textContent = '\u00A0';
this._appendNameElement(/** @type {string} */ (this._axNode.name().value));
}
}
if (this._axNode.hasOnlyUnloadedChildren()) {
- this.listItemElement.classList.add('children-unloaded');
+ this.titleElement().classList.add('children-unloaded');
this.setExpandable(true);
} else {
this.setExpandable(!!this._axNode.numChildren());
}
if (!this._axNode.isDOMNode())
- this.listItemElement.classList.add('no-dom-node');
- this.listItemElement.appendChild(this._inspectNodeButton.element);
+ this.titleElement().classList.add('no-dom-node');
+ this.titleElement().appendChild(this._inspectNodeButton.element);
}
/**
@@ -265,7 +270,7 @@ Accessibility.AXNodeTreeElement = class extends TreeElement {
var nameElement = createElement('span');
nameElement.textContent = '"' + name + '"';
nameElement.classList.add('ax-readable-string');
- this.listItemElement.appendChild(nameElement);
+ this.titleElement().appendChild(nameElement);
}
/**
@@ -279,14 +284,14 @@ Accessibility.AXNodeTreeElement = class extends TreeElement {
roleElement.classList.add(Accessibility.AXNodeTreeElement.RoleStyles[role.type]);
roleElement.setTextContentTruncatedIfNeeded(role.value || '');
- this.listItemElement.appendChild(roleElement);
+ this.titleElement().appendChild(roleElement);
}
_appendIgnoredNodeElement() {
var ignoredNodeElement = createElementWithClass('span', 'monospace');
ignoredNodeElement.textContent = Common.UIString('Ignored');
ignoredNodeElement.classList.add('ax-tree-ignored-node');
- this.listItemElement.appendChild(ignoredNodeElement);
+ this.titleElement().appendChild(ignoredNodeElement);
}
/**
@@ -359,7 +364,7 @@ Accessibility.AXNodeTreeParentElement = class extends Accessibility.AXNodeTreeEl
if (this._treePane.isExpanded(this._axNode.backendDOMNodeId()))
this.listItemElement.classList.add('siblings-expanded');
if (this._axNode.numChildren() > 1)
- this.listItemElement.insertBefore(this._expandSiblingsButton.element, this._inspectNodeButton.element);
+ this.titleElement().insertBefore(this._expandSiblingsButton.element, this._inspectNodeButton.element);
}
/**

Powered by Google App Engine
This is Rietveld 408576698