Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 256443004: Revert of Moves the notification icon out of the status area overflow. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Moves the notification icon out of the status area overflow. (https://codereview.chromium.org/110693004/) Reason for revert: From Vista Tests 1: StatusTrayStateChangerWinTest.TraySizeApiTest (run #1): [ RUN ] StatusTrayStateChangerWinTest.TraySizeApiTest c:\b\build\slave\cr-win-rel\build\src\chrome\browser\ui\views\status_icons\status_tray_state_changer_interactive_uitest_win.cc(149): error: Expected: (new_width) > (width), actual: 241 vs 241 [ FAILED ] StatusTrayStateChangerWinTest.TraySizeApiTest (94 ms) Original issue's description: > Moves the notification icon out of the status area overflow. > > This only happens the first time it is created per data dir, > so that the user can change back their setting if desired. > > This approach uses COM to talk with Windows Explorer to > change the user's notification area preferences. > > R=dimich@chromium.org > BUG=347693 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265807 TBR=dimich@chromium.org,atwilson@chromium.org,sky@chromium.org,cpu@chromium.org,dewittj@chromium.org NOTREECHECKS=true NOTRY=true BUG=347693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -766 lines) Patch
M chrome/browser/notifications/message_center_notification_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/status_icons/status_icon.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/status_icons/status_icon.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.h View 5 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.cc View 4 chunks +4 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_win.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.h View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.cc View 3 chunks +2 lines, -11 lines 0 comments Download
D chrome/browser/ui/views/status_icons/status_tray_state_changer_interactive_uitest_win.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/browser/ui/views/status_icons/status_tray_state_changer_win.h View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc View 1 chunk +0 lines, -235 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win.h View 2 chunks +12 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win.cc View 6 chunks +9 lines, -87 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc View 2 chunks +0 lines, -41 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Created Revert of Moves the notification icon out of the status area overflow.
6 years, 8 months ago (2014-04-24 03:16:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/256443004/1
6 years, 8 months ago (2014-04-24 03:17:11 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 03:17:54 UTC) #3
Message was sent while issue was closed.
Change committed as 265828

Powered by Google App Engine
This is Rietveld 408576698