Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2564413004: Make list_files.py and list_dart_files.py return absolute paths (Closed)

Created:
4 years ago by zra
Modified:
4 years ago
Reviewers:
Cutch, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make list_files.py and list_dart_files.py return absolute paths This makes doing an SDK build in the Fuchsia tree easier R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/a858542c89adb85b901d55457bd74300bc083eab

Patch Set 1 #

Patch Set 2 : Remove debug print #

Total comments: 4

Patch Set 3 : Fix long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/BUILD.gn View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M tools/list_dart_files.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/list_files.py View 1 chunk +3 lines, -1 line 0 comments Download
M utils/create_timestamp.gni View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zra
4 years ago (2016-12-12 20:48:45 UTC) #4
Cutch
LGTM wC https://codereview.chromium.org/2564413004/diff/20001/runtime/vm/BUILD.gn File runtime/vm/BUILD.gn (right): https://codereview.chromium.org/2564413004/diff/20001/runtime/vm/BUILD.gn#newcode414 runtime/vm/BUILD.gn:414: # We list all files which make ...
4 years ago (2016-12-12 20:50:09 UTC) #5
zra
https://codereview.chromium.org/2564413004/diff/20001/runtime/vm/BUILD.gn File runtime/vm/BUILD.gn (right): https://codereview.chromium.org/2564413004/diff/20001/runtime/vm/BUILD.gn#newcode414 runtime/vm/BUILD.gn:414: # We list all files which make up the ...
4 years ago (2016-12-12 20:54:22 UTC) #6
zra
4 years ago (2016-12-12 21:09:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a858542c89adb85b901d55457bd74300bc083eab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698