Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2564413003: Don't try to enter VR onResume for Cardboard mode (Closed)

Created:
4 years ago by bshe
Modified:
4 years ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Don't try to enter VR onResume for Cardboard mode This is the CL that merge the fix in https://codereview.chromium.org/2560843003/ to M56. The CL that landed in TOT has a small refactor which cause conflicts. So this CL only merge the relevent fix to M56 (stripped out the small refactor). BUG=672273 Cr-Commit-Position: refs/branch-heads/2924@{#457} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
bshe
Hi Micheal. Can you take a look? This is for merge back to M56. Only ...
4 years ago (2016-12-12 16:15:52 UTC) #2
mthiesse
lgtm
4 years ago (2016-12-12 16:38:45 UTC) #3
bshe
4 years ago (2016-12-12 17:20:58 UTC) #6
Message was sent while issue was closed.
On 2016/12/12 16:38:45, mthiesse wrote:
> lgtm

According to M56 branch, this CL landed. But somehow it not automatically
closed. I did hit ctrl+c whiling using
"git cl land" since it says failed to land due to empty commit message.
Something has gone wrong. But anyway, this
is landed to M56, so close it and manually copy Cr-Commit-Position and
Cr-Branched-From into the bug description.

Powered by Google App Engine
This is Rietveld 408576698