third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp - Issue 2564363002: ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with CallbackPromiseAdapter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

Issue 2564363002: ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with CallbackPromiseAdapter (Closed)

Patch Set: base::MakeUnique Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

index 93e1fdadf56423d2f1dba3a866b6b95be4bb49c1..f197f17fed8a26045f6ca6381ebc96dd996cd29c 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

@@ -137,6 +137,9 @@ v8::Local<v8::Value> ServiceWorkerErrorForUpdate::take(

// a TypeError.

return V8ThrowException::createTypeError(

scriptState->isolate(), getExceptionParams(webError).message);

+ case WebServiceWorkerError::ErrorTypeType:

+ return V8ThrowException::createTypeError(scriptState->isolate(),

+ webError.message);

default:

return toV8(ServiceWorkerError::take(resolver, webError),

scriptState->context()->Global(), scriptState->isolate());