Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 256433003: Make context_lost test more of a stress test. (Closed)

Created:
6 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Make context_lost test more of a stress test. This change much more reliably catches the assertion failure in Issue 365904. BUG=365904 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -24 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 2 chunks +40 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
6 years, 8 months ago (2014-04-23 22:49:44 UTC) #1
Zhenyao Mo
On 2014/04/23 22:49:44, Ken Russell wrote: > Please review. Thanks. LGTM
6 years, 8 months ago (2014-04-23 23:32:51 UTC) #2
bajones
lgtm
6 years, 8 months ago (2014-04-23 23:34:15 UTC) #3
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 8 months ago (2014-04-24 00:04:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/256433003/1
6 years, 8 months ago (2014-04-24 00:05:23 UTC) #5
commit-bot: I haz the power
Change committed as 265833
6 years, 8 months ago (2014-04-24 03:30:06 UTC) #6
dshwang
On 2014/04/24 03:30:06, I haz the power (commit-bot) wrote: > Change committed as 265833 After ...
6 years, 8 months ago (2014-04-24 08:05:59 UTC) #7
dshwang
6 years, 8 months ago (2014-04-24 08:22:57 UTC) #8
Message was sent while issue was closed.
On 2014/04/24 08:05:59, dshwang wrote:
> On 2014/04/24 03:30:06, I haz the power (commit-bot) wrote:
> > Change committed as 265833
> 
> After this CL, linux_gpu_triggered_tests becomes flaky;
>
http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...
> Interestingly, only linux_gpu is flaky.

After https://codereview.chromium.org/254453002/, it is fixed.

Powered by Google App Engine
This is Rietveld 408576698