Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2564303002: Revert "Change the way tasks are registered" (TBD) (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Change the way tasks are registered" (TBD) Committed: https://github.com/dart-lang/sdk/commit/718a17db852ea9545eabd1d9165a7323f4e928eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -88 lines) Patch
M pkg/analyzer/lib/plugin/task.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +7 lines, -88 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 7 chunks +98 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Committed patchset #1 (id:1) manually as 718a17db852ea9545eabd1d9165a7323f4e928eb (presubmit successful).
4 years ago (2016-12-11 19:32:07 UTC) #2
Brian Wilkerson
I appears to have broken snapshot generation, but I don't know why so I can't ...
4 years ago (2016-12-11 19:33:16 UTC) #4
scheglov
4 years ago (2016-12-11 19:38:49 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698