Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: components/offline_pages/core/offline_page_model_impl_unittest.cc

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/offline_page_model_impl_unittest.cc
diff --git a/components/offline_pages/core/offline_page_model_impl_unittest.cc b/components/offline_pages/core/offline_page_model_impl_unittest.cc
index 678cc7066e01e15627018ac6f0264948a00855f9..8a91783ac880a405180497a766bf67719c581d78 100644
--- a/components/offline_pages/core/offline_page_model_impl_unittest.cc
+++ b/components/offline_pages/core/offline_page_model_impl_unittest.cc
@@ -76,7 +76,6 @@ class OfflinePageModelImplTest
void TearDown() override;
// OfflinePageModel::Observer implementation.
- void OfflinePageModelLoaded(OfflinePageModel* model) override;
void OfflinePageAdded(OfflinePageModel* model,
const OfflinePageItem& added_page) override;
void OfflinePageDeleted(int64_t offline_id,
@@ -229,10 +228,6 @@ void OfflinePageModelImplTest::TearDown() {
PumpLoop();
}
-void OfflinePageModelImplTest::OfflinePageModelLoaded(OfflinePageModel* model) {
- ASSERT_EQ(model_.get(), model);
-}
-
void OfflinePageModelImplTest::OfflinePageDeleted(int64_t offline_id,
const ClientId& client_id) {
last_deleted_offline_id_ = offline_id;
@@ -1197,7 +1192,6 @@ TEST_F(OfflinePageModelImplTest, StoreResetSuccessful) {
const std::vector<OfflinePageItem>& offline_pages = GetAllPages();
- EXPECT_TRUE(model()->is_loaded());
EXPECT_EQ(StoreState::LOADED, GetStore()->state());
EXPECT_EQ(0UL, offline_pages.size());
@@ -1214,7 +1208,6 @@ TEST_F(OfflinePageModelImplTest, StoreResetFailed) {
const std::vector<OfflinePageItem>& offline_pages = GetAllPages();
- EXPECT_TRUE(model()->is_loaded());
EXPECT_EQ(StoreState::FAILED_RESET, GetStore()->state());
EXPECT_EQ(0UL, offline_pages.size());

Powered by Google App Engine
This is Rietveld 408576698