Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: components/ntp_snippets/offline_pages/offline_pages_test_utils.cc

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/offline_pages/offline_pages_test_utils.h" 5 #include "components/ntp_snippets/offline_pages/offline_pages_test_utils.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/guid.h" 10 #include "base/guid.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 13
14 using offline_pages::ClientId; 14 using offline_pages::ClientId;
15 using offline_pages::MultipleOfflinePageItemCallback; 15 using offline_pages::MultipleOfflinePageItemCallback;
16 using offline_pages::OfflinePageItem; 16 using offline_pages::OfflinePageItem;
17 using offline_pages::StubOfflinePageModel; 17 using offline_pages::StubOfflinePageModel;
18 18
19 namespace ntp_snippets { 19 namespace ntp_snippets {
20 namespace test { 20 namespace test {
21 21
22 FakeOfflinePageModel::FakeOfflinePageModel() { 22 FakeOfflinePageModel::FakeOfflinePageModel() {
vitaliii 2016/12/15 10:20:37 = default?
23 // This is to match StubOfflinePageModel behavior.
24 is_loaded_ = true;
25 } 23 }
26 24
27 FakeOfflinePageModel::~FakeOfflinePageModel() = default; 25 FakeOfflinePageModel::~FakeOfflinePageModel() = default;
28 26
29 void FakeOfflinePageModel::GetPagesMatchingQuery( 27 void FakeOfflinePageModel::GetPagesMatchingQuery(
30 std::unique_ptr<offline_pages::OfflinePageModelQuery> query, 28 std::unique_ptr<offline_pages::OfflinePageModelQuery> query,
31 const MultipleOfflinePageItemCallback& callback) { 29 const MultipleOfflinePageItemCallback& callback) {
32 MultipleOfflinePageItemResult filtered_result; 30 MultipleOfflinePageItemResult filtered_result;
33 for (auto& item : items_) { 31 for (auto& item : items_) {
34 if (query->Matches(item)) { 32 if (query->Matches(item)) {
35 filtered_result.emplace_back(item); 33 filtered_result.emplace_back(item);
36 } 34 }
37 } 35 }
38 callback.Run(filtered_result); 36 callback.Run(filtered_result);
39 } 37 }
40 38
41 void FakeOfflinePageModel::GetAllPages( 39 void FakeOfflinePageModel::GetAllPages(
42 const MultipleOfflinePageItemCallback& callback) { 40 const MultipleOfflinePageItemCallback& callback) {
43 callback.Run(items_); 41 callback.Run(items_);
44 } 42 }
45 43
46 const std::vector<OfflinePageItem>& FakeOfflinePageModel::items() { 44 const std::vector<OfflinePageItem>& FakeOfflinePageModel::items() {
47 return items_; 45 return items_;
48 } 46 }
49 47
50 std::vector<OfflinePageItem>* FakeOfflinePageModel::mutable_items() { 48 std::vector<OfflinePageItem>* FakeOfflinePageModel::mutable_items() {
51 return &items_; 49 return &items_;
52 } 50 }
53 51
54 bool FakeOfflinePageModel::is_loaded() const {
55 return is_loaded_;
56 }
57
58 void FakeOfflinePageModel::set_is_loaded(bool value) {
59 is_loaded_ = value;
60 }
61
62 OfflinePageItem CreateDummyOfflinePageItem(int id, 52 OfflinePageItem CreateDummyOfflinePageItem(int id,
63 const std::string& name_space) { 53 const std::string& name_space) {
64 std::string id_string = base::IntToString(id); 54 std::string id_string = base::IntToString(id);
65 return OfflinePageItem( 55 return OfflinePageItem(
66 GURL("http://dummy.com/" + id_string), id, 56 GURL("http://dummy.com/" + id_string), id,
67 ClientId(name_space, base::GenerateGUID()), 57 ClientId(name_space, base::GenerateGUID()),
68 base::FilePath::FromUTF8Unsafe("some/folder/test" + id_string + ".mhtml"), 58 base::FilePath::FromUTF8Unsafe("some/folder/test" + id_string + ".mhtml"),
69 0, base::Time::Now()); 59 0, base::Time::Now());
70 } 60 }
71 61
72 void CaptureDismissedSuggestions( 62 void CaptureDismissedSuggestions(
73 std::vector<ContentSuggestion>* captured_suggestions, 63 std::vector<ContentSuggestion>* captured_suggestions,
74 std::vector<ContentSuggestion> dismissed_suggestions) { 64 std::vector<ContentSuggestion> dismissed_suggestions) {
75 std::move(dismissed_suggestions.begin(), dismissed_suggestions.end(), 65 std::move(dismissed_suggestions.begin(), dismissed_suggestions.end(),
76 std::back_inserter(*captured_suggestions)); 66 std::back_inserter(*captured_suggestions));
77 } 67 }
78 68
79 } // namespace test 69 } // namespace test
80 } // namespace ntp_snippets 70 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698