[Offline Pages] Remove load state from public OfflinePageModel API.

chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ntp_snippets/download_suggestions_provider.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/observer_list.h"
@@ skipping 253 matching lines @@
     return provider_.get();
   }
 
   void DestroyProvider() { provider_.reset(); }
 
   Category downloads_category() {
     return category_factory_.FromKnownCategory(
         ntp_snippets::KnownCategories::DOWNLOADS);
   }
 
-  void FireOfflinePageModelLoaded() {
-    DCHECK(provider_);
-    provider_->OfflinePageModelLoaded(&offline_pages_model_);
-  }
-
   void AddOfflinePage(const offline_pages::OfflinePageItem& added_page) {
     DCHECK(provider_);
     offline_pages_model_.mutable_items()->push_back(added_page);
     provider_->OfflinePageAdded(&offline_pages_model_, added_page);
   }
 
   void FireOfflinePageDeleted(const OfflinePageItem& item) {
     DCHECK(provider_);
     provider_->OfflinePageDeleted(item.offline_id, item.client_id);
   }
@@ skipping 585 matching lines @@
                                                 HasUrl("http://dummy.com/2"))));
   CreateProvider(/*show_assets=*/false, /*show_offline_pages=*/true);
   downloads_manager()->NotifyDownloadCreated(
       downloads_manager()->items()[0].get());
   // This notification should not reach the provider, because the asset
   // downloads data source is not provided. If it is and the provider reacts to
   // the notification, the test will fail because the observer is a strict mock.
   (*downloads_manager()->mutable_items())[0]->NotifyDownloadUpdated();
 }
 
-TEST_F(DownloadSuggestionsProviderTest, ShouldLoadOfflinePagesOnModelLoaded) {
-  IgnoreOnCategoryStatusChangedToAvailable();
-  IgnoreOnSuggestionInvalidated();
-
-  offline_pages_model()->set_is_loaded(false);
-  EXPECT_CALL(*observer(),
-              OnNewSuggestions(_, downloads_category(), IsEmpty()));
-  CreateProvider(/*show_assets=*/true, /*show_offline_pages=*/true);
-
-  *(offline_pages_model()->mutable_items()) = CreateDummyOfflinePages({1, 2});
-  offline_pages_model()->set_is_loaded(true);
-  EXPECT_CALL(*observer(), OnNewSuggestions(_, downloads_category(),
-                                            UnorderedElementsAre(
-                                                HasUrl("http://dummy.com/1"),
-                                                HasUrl("http://dummy.com/2"))));
-  FireOfflinePageModelLoaded();
-}
-
 TEST_F(DownloadSuggestionsProviderTest,
        ShouldLoadOfflinePagesIfMissesOnModelLoaded) {

[vitaliii, 2016/12/15 10:20:37]

This test must be renamed, since the OfflinePageModelLoaded notification has
been removed. I would call it "ShouldFetchOfflinePagesOnStartup".

   IgnoreOnCategoryStatusChangedToAvailable();
   IgnoreOnSuggestionInvalidated();
 
   *(offline_pages_model()->mutable_items()) = CreateDummyOfflinePages({1, 2});
-  offline_pages_model()->set_is_loaded(true);
   EXPECT_CALL(*observer(), OnNewSuggestions(_, downloads_category(),
                                             UnorderedElementsAre(
                                                 HasUrl("http://dummy.com/1"),
                                                 HasUrl("http://dummy.com/2"))));
   CreateProvider(/*show_assets=*/true, /*show_offline_pages=*/true);
 }
 
 TEST_F(DownloadSuggestionsProviderTest,
        ShouldLoadAndSubmitMissedAssetsEvenIfOfflinePagesAreTurnedOff) {
   IgnoreOnCategoryStatusChangedToAvailable();
   IgnoreOnSuggestionInvalidated();
 
   *(downloads_manager()->mutable_items()) = CreateDummyAssetDownloads({1, 2});
   EXPECT_CALL(
       *observer(),
       OnNewSuggestions(_, downloads_category(),
                        UnorderedElementsAre(HasUrl("http://download.com/1"),
                                             HasUrl("http://download.com/2"))));
   CreateProvider(/*show_assets=*/true, /*show_offline_pages=*/false);
 }