[Offline Pages] Remove load state from public OfflinePageModel API.

chrome/browser/ntp_snippets/download_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ntp_snippets/download_suggestions_provider.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 282 matching lines @@
     for (const DownloadItem* item : all_downloads) {
       if (dismissed_ids.count(GetAssetDownloadPerCategoryID(item->GetId()))) {
         suggestions.push_back(ConvertDownloadItem(*item));
       }
     }
   }
 
   callback.Run(std::move(suggestions));
 }
 
-void DownloadSuggestionsProvider::OfflinePageModelLoaded(
-    offline_pages::OfflinePageModel* model) {
-  DCHECK_EQ(offline_page_model_, model);
-  AsynchronouslyFetchOfflinePagesDownloads(/*notify=*/true);

[Marc Treib, 2016/12/13 10:11:02]

I guess we don't need this call, because we'll get OfflinePageAdded
notifications anyway? Or should we now call this when the provider is created?

[vitaliii, 2016/12/15 10:20:37]

I believe that even if we get OfflinePageAdded, we may miss some of them at
startup.

-}
-
 void DownloadSuggestionsProvider::OfflinePageAdded(
     offline_pages::OfflinePageModel* model,
     const offline_pages::OfflinePageItem& added_page) {
   // TODO(dewittj, vitaliii): Don't refetch everything when this is called.
   DCHECK_EQ(offline_page_model_, model);
   AsynchronouslyFetchOfflinePagesDownloads(/*notify=*/true);
 }
 
 void DownloadSuggestionsProvider::OfflinePageDeleted(
     int64_t offline_id,
@@ skipping 74 matching lines @@
 
 void DownloadSuggestionsProvider::AsynchronouslyFetchOfflinePagesDownloads(
     bool notify) {
   if (!offline_page_model_) {
     // Offline pages are explicitly turned off, so we propagate "no pages"
     // further e.g. to clean its prefs.
     UpdateOfflinePagesCache(notify, std::vector<OfflinePageItem>());
     return;
   }
 
-  if (!offline_page_model_->is_loaded()) {
-    // Offline pages model is not ready yet and may return no offline pages.
-    if (notify) {
-      SubmitContentSuggestions();
-    }
-
-    return;
-  }
-
   offline_page_model_->GetPagesMatchingQuery(
       BuildOfflinePageDownloadsQuery(offline_page_model_),
       base::Bind(&DownloadSuggestionsProvider::UpdateOfflinePagesCache,
                  weak_ptr_factory_.GetWeakPtr(), notify));
 }
 
 void DownloadSuggestionsProvider::FetchAssetsDownloads() {
   if (!download_manager_) {
     // The manager has gone down or was explicitly turned off.
     return;
@@ skipping 202 matching lines @@
       // The same as the case above.
       FetchAssetsDownloads();
     }
   }
 }
 
 void DownloadSuggestionsProvider::UpdateOfflinePagesCache(
     bool notify,
     const std::vector<offline_pages::OfflinePageItem>&
         all_download_offline_pages) {
-  DCHECK(!offline_page_model_ || offline_page_model_->is_loaded());
-
   std::set<std::string> old_dismissed_ids =
       ReadOfflinePageDismissedIDsFromPrefs();
   std::set<std::string> retained_dismissed_ids;
   std::vector<const OfflinePageItem*> items;
   // Filtering out dismissed items and pruning dismissed IDs.
   for (const OfflinePageItem& item : all_download_offline_pages) {
     std::string id_within_category =
         GetOfflinePagePerCategoryID(item.offline_id);
     if (!old_dismissed_ids.count(id_within_category)) {
       items.push_back(&item);
@@ skipping 101 matching lines @@
 void DownloadSuggestionsProvider::UnregisterDownloadItemObservers() {
   DCHECK_NE(download_manager_, nullptr);
 
   std::vector<DownloadItem*> all_downloads;
   download_manager_->GetAllDownloads(&all_downloads);
 
   for (DownloadItem* item : all_downloads) {
     item->RemoveObserver(this);
   }
 }