Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 256413007: Remove changes remaining counter from about:sync (Closed)

Created:
6 years, 8 months ago by rlarocque
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Remove changes remaining counter from about:sync The label "changes remaining" is not quite correct. It's actually set to either zero or one, depending on whether or not the current sync cycle should result in more downloads. If there is an issue with infinite download looping, we should be able to detect and debug it based on the protocol logs, among other things. The protocol logs indicate when a GetUpdates response had a non-zero "changes remaining" value. BUG=349301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -50 lines) Patch
M chrome/browser/sync/about_sync_util.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M sync/engine/all_status.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M sync/engine/get_updates_processor.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/engine/sync_status.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/internal_api/public/engine/sync_status.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/sessions/model_neutral_state.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sync/internal_api/public/sessions/model_neutral_state.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M sync/sessions/status_controller.h View 2 chunks +0 lines, -6 lines 0 comments Download
M sync/sessions/status_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M sync/sessions/status_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/sessions/test_util.cc View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rlarocque
Please review.
6 years, 8 months ago (2014-04-24 20:08:59 UTC) #1
tim (not reviewing)
LGTM
6 years, 8 months ago (2014-04-25 16:28:18 UTC) #2
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 8 months ago (2014-04-25 17:28:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/256413007/1
6 years, 8 months ago (2014-04-25 22:14:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:19:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 23:19:57 UTC) #6
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 8 months ago (2014-04-25 23:39:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/256413007/1
6 years, 8 months ago (2014-04-25 23:40:48 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 03:53:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 03:53:54 UTC) #10
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 7 months ago (2014-04-28 17:24:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/256413007/1
6 years, 7 months ago (2014-04-28 17:25:03 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 17:25:44 UTC) #13
Message was sent while issue was closed.
Change committed as 266594

Powered by Google App Engine
This is Rietveld 408576698