Issue 256413006: Fix android_gdbserver script to work with changes from a137675.

Issue 256413006: Fix android_gdbserver script to work with changes from a137675. (Closed)

Created:
6 years, 8 months ago by hal.canary

Modified:
6 years, 8 months ago

Reviewers:
mtklein, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Fix android_gdbserver script to work with changes from a137675. Also stop assuming ANDROID_ARCH one of x86 or arm. NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14358

Patch Set 1 : AnotherPatchSet #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -37 lines)			Patch
M	platform_tools/android/bin/android_gdb_apk	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	platform_tools/android/bin/android_gdb_exe	View	2 chunks	+3 lines, -6 lines	2 comments	Download
M	platform_tools/android/bin/android_gdbserver	View	3 chunks	+15 lines, -25 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/256413006/20001

6 years, 8 months ago (2014-04-24 18:36:23 UTC) #4

djsollen

https://codereview.chromium.org/256413006/diff/20001/platform_tools/android/bin/android_gdb_exe File platform_tools/android/bin/android_gdb_exe (right): https://codereview.chromium.org/256413006/diff/20001/platform_tools/android/bin/android_gdb_exe#newcode9 platform_tools/android/bin/android_gdb_exe:9: export BUILDTYPE # from android_setup.sh what did this line ...

6 years, 8 months ago (2014-04-25 17:42:54 UTC) #6

hal.canary

6 years, 8 months ago (2014-04-25 18:38:19 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/256413006/diff/20001/platform_tools/android/b...
File platform_tools/android/bin/android_gdb_exe (right):

https://codereview.chromium.org/256413006/diff/20001/platform_tools/android/b...
platform_tools/android/bin/android_gdb_exe:9: export BUILDTYPE  # from
android_setup.sh
On 2014/04/25 17:42:54, djsollen wrote:
> what did this line do exactly?

So android_gdbserver sees this variable as set by android_setup

Expand Messages | Collapse Messages