Issue 25641002: Add builder option (kill_internal_links) to hide all links to in-tree documents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25641002: Add builder option (kill_internal_links) to hide all links to in-tree documents. (Closed)

Created:
7 years, 2 months ago by eliben

Modified:
7 years, 2 months ago

Reviewers:
Sam Clegg, binji, Andy

CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add builder option (kill_internal_links) to hide all links to in-tree documents. This can be used to generate partial trees of documents where not all documents exist yet so links won't be stale. The option is off by default and has to be passed to sphinx-build explicitly with -D kill_internal_links=1 BUG=None R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226350

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	native_client_sdk/src/doc/_sphinxext/devsite_builder.py	View		3 chunks	+18 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

lgtm https://codereview.chromium.org/25641002/diff/1/native_client_sdk/src/doc/_sphinxext/devsite_builder.py File native_client_sdk/src/doc/_sphinxext/devsite_builder.py (right): https://codereview.chromium.org/25641002/diff/1/native_client_sdk/src/doc/_sphinxext/devsite_builder.py#newcode328 native_client_sdk/src/doc/_sphinxext/devsite_builder.py:328: Kill extra line.

7 years, 2 months ago (2013-10-01 23:45:46 UTC) #2

eliben

On 2013/10/01 23:45:46, Sam Clegg wrote: > lgtm > > https://codereview.chromium.org/25641002/diff/1/native_client_sdk/src/doc/_sphinxext/devsite_builder.py > File native_client_sdk/src/doc/_sphinxext/devsite_builder.py (right): ...

7 years, 2 months ago (2013-10-01 23:52:23 UTC) #3

eliben

7 years, 2 months ago (2013-10-01 23:53:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r226350 (presubmit successful).

Expand Messages | Collapse Messages