chrome/browser/supervised_user/supervised_user_resource_throttle.cc - Issue 2564043002: Supervised Users: Create ResourceThrottle only if filtering is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_resource_throttle.cc

Issue 2564043002: Supervised Users: Create ResourceThrottle only if filtering is enabled (Closed)

Patch Set: update SearchTest Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search/search_unittest.cc ('k') | chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_resource_throttle.cc

diff --git a/chrome/browser/supervised_user/supervised_user_resource_throttle.cc b/chrome/browser/supervised_user/supervised_user_resource_throttle.cc

index a0695f62832cb69fde6718abf6ec87705b757bce..53df77ad41091d8249c0142e290fb467b7dfcdaf 100644

--- a/chrome/browser/supervised_user/supervised_user_resource_throttle.cc

+++ b/chrome/browser/supervised_user/supervised_user_resource_throttle.cc

@@ -117,7 +117,7 @@ SupervisedUserResourceThrottle::MaybeCreate(

const SupervisedUserURLFilter* url_filter) {

// Only treat main frame requests (ignoring subframes and subresources).

bool is_main_frame = resource_type == content::RESOURCE_TYPE_MAIN_FRAME;

- if (!is_main_frame)

+ if (!is_main_frame || !url_filter->enabled())

return nullptr;

// Can't use base::MakeUnique because the constructor is private.