Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 256403004: Move Mojo channel initialization closer to IPC::Channel setup (Closed)

Created:
6 years, 8 months ago by darin (slow to review)
Modified:
6 years, 8 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, creis+watch_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, ben+mojo_chromium.org
Visibility:
Public.

Description

Move Mojo channel initialization closer to IPC::Channel setup This CL introduces two new content classes: - MojoApplicationHost encapsulates what's needed to host a Mojo App using Chrome IPC to bootstrap. - MojoApplication represents what's needed to be a Mojo App using Chrome IPC to bootstrap. The RenderProcess and RenderProcessHost interfaces are replaced with WebUISetup and WebUISetupClient interfaces. This way the interface is more specific to the service of setting up WebUI. WebUISetupClient is empty and uninteresting. RenderProcessHostImpl no longer deals with WebUI setup. That is all done directly by RenderViewHostImpl by talking to the WebUISetup service. Service names get defined in content/common/mojo/mojo_service_names.{h,cc}. TBR=sky@chromium.org, tsepez@chromium.org Originally reviewed at https://codereview.chromium.org/236813002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265962

Patch Set 1 #

Patch Set 2 : attempt to fix ios runhooks #

Patch Set 3 : make ios happy #

Patch Set 4 : another ios fix #

Patch Set 5 : another ios fix #

Patch Set 6 : another ios fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+477 lines, -499 lines) Patch
M content/app/content_main_runner.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 3 chunks +6 lines, -1 line 0 comments Download
A content/browser/mojo/mojo_application_host.h View 1 chunk +51 lines, -0 lines 0 comments Download
A content/browser/mojo/mojo_application_host.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M content/browser/renderer_data_memoizing_store.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 3 4 5 chunks +10 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 9 chunks +25 lines, -10 lines 0 comments Download
D content/browser/renderer_host/render_process_host_mojo_impl.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/browser/renderer_host/render_process_host_mojo_impl.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M content/child/child_thread.h View 5 chunks +12 lines, -1 line 0 comments Download
M content/child/child_thread.cc View 4 chunks +13 lines, -0 lines 0 comments Download
A content/child/mojo/mojo_application.h View 1 chunk +47 lines, -0 lines 0 comments Download
A content/child/mojo/mojo_application.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M content/common/mojo/mojo_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
A content/common/mojo/mojo_service_names.h View 1 chunk +18 lines, -0 lines 0 comments Download
A + content/common/mojo/mojo_service_names.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D content/common/mojo/render_process.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
A content/common/web_ui_setup.mojom View 1 chunk +16 lines, -0 lines 0 comments Download
M content/content_app.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M content/content_child.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common_mojo_bindings.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_plugin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_utility.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_worker.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
D content/renderer/mojo/mojo_render_process_observer.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/renderer/mojo/mojo_render_process_observer.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 6 chunks +14 lines, -4 lines 0 comments Download
A content/renderer/web_ui_setup_impl.h View 1 chunk +39 lines, -0 lines 0 comments Download
A content/renderer/web_ui_setup_impl.cc View 1 chunk +41 lines, -0 lines 0 comments Download
A + mojo/common/channel_init.h View 3 chunks +15 lines, -22 lines 0 comments Download
A + mojo/common/channel_init.cc View 3 chunks +9 lines, -9 lines 0 comments Download
D mojo/common/mojo_channel_init.h View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/common/mojo_channel_init.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
Note, this is just a minor delta from https://codereview.chromium.org/236813002/, which you already reviewed. The changes ...
6 years, 8 months ago (2014-04-24 18:16:26 UTC) #1
darin (slow to review)
6 years, 8 months ago (2014-04-24 18:18:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #6 manually as r265962 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698